threads / patch / 4253

patchSet the executable bit on gitMergeCommon.py.

Subject: [PATCH] Set the executable bit on gitMergeCommon.py.

## tl;dr

2 messages between May 23, 2006 and May 23, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Peter Eriksen· May 23, 2006, 08:12 UTC · lore

From: Peter Eriksen <s022018@student.dtu.dk>
Date: Mon, 22 May 2006 15:35:42 +0200

Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>

---

6465b4c8cc760102ed5771ccded2c02904539475
 0 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 gitMergeCommon.py

6465b4c8cc760102ed5771ccded2c02904539475

Show changes to gitMergeCommon.py +0 −0

diff --git a/gitMergeCommon.py b/gitMergeCommon.py
old mode 100644
new mode 100755

-- 
1.3.3.g288c

Junio C Hamano· May 23, 2006, 08:34 UTC · re: Peter Eriksen · lore

Re: [PATCH] Set the executable bit on gitMergeCommon.py.

"Peter Eriksen" <s022018@student.dtu.dk> writes:

> From: Peter Eriksen <s022018@student.dtu.dk>
> Date: Mon, 22 May 2006 15:35:42 +0200
>
> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>

It makes some sense to make git-merge-recursive.py executable, just in case somebody wants to run it without preprocessing.

However, gitMergeCommon.py is a module without the main program. It does not even have the usual "primarily meant to be a library but you could run it standalone" idiom at the end:

	if __name__ == '__main__': test()

So I am not sure if this patch makes sense -- does it misbehave on your system when installed without +x bit?