# [PATCH 2/2] completion: add git status 3 messages from 2016-05-31 to 2016-06-01. Participants: Thomas Braun, Jeff King. Thread: https://gitlist.dev/t/42503 ## Thomas Braun, 2016-05-31 23:42 Subject: [PATCH 2/2] completion: add git status Message-ID: URL: https://gitlist.dev/e/b881e8b7-8364-f78b-d7ac-817850783c6e%40virtuell-zuhause.de ``` Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 57a0acc..96b7d86 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1782,6 +1782,35 @@ _git_stage () _git_add } +_git_status () +{ + case "$cur" in + --ignore-submodules=*) + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}" + return + ;; + --untracked-files=*) + __gitcomp "$(__git_untracked_file_modes)" "" "${cur##--untracked-files=}" + return + ;; + --column=*) + __gitcomp " + always never auto column row plain dense nodense + " "" "${cur##--column=}" + return + ;; + --*) + __gitcomp " + --short --branch --porcelain --long --verbose + --untracked-files= --ignore-submodules= --ignored + --column= --no-column + " + return + ;; + esac + __git_complete_file +} + __git_config_get_set_variables () { local prevword word config_file= c=$cword -- 2.8.3.windows.1 ``` ## Jeff King, 2016-06-01 04:07 Subject: Re: [PATCH 2/2] completion: add git status Message-ID: <20160601040722.GB18978@sigill.intra.peff.net> URL: https://gitlist.dev/e/20160601040722.GB18978%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote: > Signed-off-by: Thomas Braun > --- > contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 57a0acc..96b7d86 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1782,6 +1782,35 @@ _git_stage () > _git_add > } > +_git_status () This patch has the same funniness as the other. Weird. > +{ > + case "$cur" in > + --ignore-submodules=*) > + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}" > + return > + ;; > + --untracked-files=*) > + __gitcomp "$(__git_untracked_file_modes)" "" "${cur##--untracked-files=}" Same comment on $() here. > + return > + ;; > + --column=*) > + __gitcomp " > + always never auto column row plain dense nodense > + " "" "${cur##--column=}" > + return > + ;; > + --*) > + __gitcomp " > + --short --branch --porcelain --long --verbose > + --untracked-files= --ignore-submodules= --ignored > + --column= --no-column > + " > + return > + ;; > + esac > + __git_complete_file > +} The rest of it (both the overall goal, and the patch itself) look OK to me. -Peff ``` ## Thomas Braun, 2016-06-01 09:05 Subject: Re: [PATCH 2/2] completion: add git status Message-ID: <5ce10133-e982-4c02-7f97-77d03231e677@virtuell-zuhause.de> URL: https://gitlist.dev/e/5ce10133-e982-4c02-7f97-77d03231e677%40virtuell-zuhause.de In-Reply-To: <20160601040722.GB18978@sigill.intra.peff.net> ``` > Jeff King hat am 1. Juni 2016 um 06:07 geschrieben: > > > On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote: > > > Signed-off-by: Thomas Braun > > --- > > contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/contrib/completion/git-completion.bash > > b/contrib/completion/git-completion.bash > > index 57a0acc..96b7d86 100644 > > --- a/contrib/completion/git-completion.bash > > +++ b/contrib/completion/git-completion.bash > > @@ -1782,6 +1782,35 @@ _git_stage () > > _git_add > > } > > +_git_status () > > This patch has the same funniness as the other. Weird. Should be fixed now. > > +{ > > + case "$cur" in > > + --ignore-submodules=*) > > + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}" > > + return > > + ;; > > + --untracked-files=*) > > + __gitcomp "$(__git_untracked_file_modes)" "" "${cur##--untracked-files=}" > > Same comment on $() here. Fixed. > > + return > > + ;; > > + --column=*) > > + __gitcomp " > > + always never auto column row plain dense nodense > > + " "" "${cur##--column=}" > > + return > > + ;; > > + --*) > > + __gitcomp " > > + --short --branch --porcelain --long --verbose > > + --untracked-files= --ignore-submodules= --ignored > > + --column= --no-column > > + " > > + return > > + ;; > > + esac > > + __git_complete_file > > +} > > The rest of it (both the overall goal, and the patch itself) look OK to > me. Thanks, Thomas ```