threads / patch / 42354

patch, 2 partsIgnore dirty submodule states during stash

Subject: [PATCH v1 0/2] Ignore dirty submodule states during stash

## tl;dr

4 messages between May 17, 2016 and May 17, 2016. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Vasily Titskiy· May 17, 2016, 03:36 UTC · lore

Impoved description + added test

 git-stash.sh     |  2 +-
 t/t3903-stash.sh | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)

Vasily Titskiy· May 17, 2016, 03:40 UTC · re: Vasily Titskiy · lore

Re: [PATCH v1 1/2] Ignore dirty submodule states during stash

As stash does not know how to deal with submodules, it should not try to save/restore their states as it leads to redundant merge conflicts.

Signed-off-by: Vasily Titskiy <qehgt0@gmail.com>
---
 git-stash.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to git-stash.sh +1 −1

diff --git a/git-stash.sh b/git-stash.sh
index c7c65e2..b500c44 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -116,7 +116,7 @@ create_stash () {
 			git read-tree --index-output="$TMPindex" -m $i_tree &&
 			GIT_INDEX_FILE="$TMPindex" &&
 			export GIT_INDEX_FILE &&
-			git diff --name-only -z HEAD -- >"$TMP-stagenames" &&
+			git diff --name-only --ignore-submodules -z HEAD -- >"$TMP-stagenames" &&
 			git update-index -z --add --remove --stdin <"$TMP-stagenames" &&
 			git write-tree &&
 			rm -f "$TMPindex"

-- 
2.1.4

Vasily Titskiy· May 17, 2016, 03:40 UTC · re: Vasily Titskiy · lore

Re: [PATCH v1 2/2] Ignore dirty submodule states during stash

It checks if 'stash pop' does not trigger merge conflics
in submodules.
---
 t/t3903-stash.sh | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

Show changes to t/t3903-stash.sh +35 −0

diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 2142c1f..e48a5b5 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -731,4 +731,39 @@ test_expect_success 'stash list --cc shows combined diff' '
 	test_cmp expect actual
 '
 
+test_expect_success 'stash ignores changes in submodules' '
+	git submodule init &&
+	git init sub1 &&
+	(
+		cd sub1 &&
+		echo "x" > file1 &&
+		git add file1 &&
+		git commit -a -m "initial sub1"
+	) &&
+	git submodule add ./. sub1 &&
+	echo "main" > file1 &&
+	git add file1 &&
+	git commit -a -m "initial main" &&
+	# make changes in submodule
+	(
+		cd sub1 &&
+		echo "y" >> file1 &&
+		git commit -a -m "change y"
+	) &&
+	git commit sub1 -m "update reference" &&
+	# switch submodule to another revision
+	(
+		cd sub1 &&
+		echo "z" >> file1 &&
+		git commit -a -m "change z"
+	) &&
+	# everything is prepared, check if changes in submodules are ignored
+	echo "local change" >> file1 &&
+	git stash save &&
+	git checkout HEAD~1 &&
+	git submodule update &&
+	git stash pop
+'
+
+
 test_done

-- 
2.1.4

Eric Sunshine· May 17, 2016, 03:49 UTC · re: Vasily Titskiy · lore

Re: [PATCH v1 2/2] Ignore dirty submodule states during stash

On Mon, May 16, 2016 at 11:40 PM, Vasily Titskiy <qehgt0@gmail.com> wrote:

> It checks if 'stash pop' does not trigger merge conflics
> in submodules.

Missing sign-off.

Also, it would be best to combine these two patches so that the fix and patch reside in a single patch.

More below...

Show 9 quoted lines

> ---
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> @@ -731,4 +731,39 @@ test_expect_success 'stash list --cc shows combined diff' '
> +test_expect_success 'stash ignores changes in submodules' '
> +       git submodule init &&
> +       git init sub1 &&
> +       (
> +               cd sub1 &&
> +               echo "x" > file1 &&

Style: Drop space after redirection operator: >file1

Ditto below for both '>' and '>>'.

Show 29 quoted lines

> +               git add file1 &&
> +               git commit -a -m "initial sub1"
> +       ) &&
> +       git submodule add ./. sub1 &&
> +       echo "main" > file1 &&
> +       git add file1 &&
> +       git commit -a -m "initial main" &&
> +       # make changes in submodule
> +       (
> +               cd sub1 &&
> +               echo "y" >> file1 &&
> +               git commit -a -m "change y"
> +       ) &&
> +       git commit sub1 -m "update reference" &&
> +       # switch submodule to another revision
> +       (
> +               cd sub1 &&
> +               echo "z" >> file1 &&
> +               git commit -a -m "change z"
> +       ) &&
> +       # everything is prepared, check if changes in submodules are ignored
> +       echo "local change" >> file1 &&
> +       git stash save &&
> +       git checkout HEAD~1 &&
> +       git submodule update &&
> +       git stash pop
> +'
> +
> +

Style: drop extra blank line

>  test_done
> --
> 2.1.4