# [PATCH] attr: explain the lack of attr-name syntax check in parse_attr()

1 messages from 2016-05-15 to 2016-05-15. Participants: Junio C Hamano.
Thread: https://gitlist.dev/t/42335

## Junio C Hamano, 2016-05-15 22:58

Subject: [PATCH] attr: explain the lack of attr-name syntax check in parse_attr()
Message-ID: <xmqqa8jr3p3z.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqa8jr3p3z.fsf%40gitster.mtv.corp.google.com

```

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 attr.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/attr.c b/attr.c
index 94b27f4..aac5c8f 100644
--- a/attr.c
+++ b/attr.c
@@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp,
 			return NULL;
 		}
 	} else {
+		/*
+		 * As this function is always called twice, once with
+		 * e == NULL in the first pass and then e != NULL in
+		 * the second pass, no need for invalid_attr_name()
+		 * check here.
+		 */
 		if (*cp == '-' || *cp == '!') {
 			e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET;
 			cp++;
-- 
2.8.2-748-gfb85f76

```