# [PATCH] compress output of `cd' when installing templates 3 messages from 2006-05-21 to 2006-05-21. Participants: Gang Chen, Timo Hirvonen, Junio C Hamano. Thread: https://gitlist.dev/t/4232 ## Gang Chen, 2006-05-21 15:41 Subject: [PATCH] compress output of `cd' when installing templates Message-ID: <83mzdbjshd.fsf@skypiea.yi.org> URL: https://gitlist.dev/e/83mzdbjshd.fsf%40skypiea.yi.org ``` When CDPATH is set in Bash, `cd' writes new working directory to stdout, which corrupts output of `tar cf - .'. Signed-off-by: Gang Chen --- Makefile | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/Makefile b/templates/Makefile index 8f7f4fe..cb67489 100644 --- a/templates/Makefile +++ b/templates/Makefile @@ -44,5 +44,5 @@ clean: install: all $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir)) - (cd blt && $(TAR) cf - .) | \ + (cd blt > /dev/null && $(TAR) cf - .) | \ (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf -) -- If it makes you happy, it can't be that bad. ``` ## Timo Hirvonen, 2006-05-21 15:54 Subject: Re: [PATCH] compress output of `cd' when installing templates Message-ID: <20060521185421.a91bf118.tihirvon@gmail.com> URL: https://gitlist.dev/e/20060521185421.a91bf118.tihirvon%40gmail.com In-Reply-To: <83mzdbjshd.fsf@skypiea.yi.org> ``` Gang Chen wrote: > When CDPATH is set in Bash, `cd' writes new working directory to > stdout, which corrupts output of `tar cf - .'. Fix bash instead, or just don't export CDPATH. It is used by bash only so exporting it is unnecessary. -- http://onion.dynserv.net/~timo/ ``` ## Junio C Hamano, 2006-05-21 18:23 Subject: Re: [PATCH] compress output of `cd' when installing templates Message-ID: <7vy7wvi6dr.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vy7wvi6dr.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20060521185421.a91bf118.tihirvon@gmail.com> ``` Timo Hirvonen writes: > Gang Chen wrote: > >> When CDPATH is set in Bash, `cd' writes new working directory to >> stdout, which corrupts output of `tar cf - .'. > > Fix bash instead, or just don't export CDPATH. It is used by bash only > so exporting it is unnecessary. Thanks. It is not just unnecessary, but "export CDPATH" anywhere in your rc scripts is actively *WRONG*. ```