# [PATCH] t6030: explicitly test for bisection cleanup 4 messages from 2016-05-13 to 2016-05-27. Participants: Pranit Bauva, Christian Couder. Thread: https://gitlist.dev/t/42302 ## Pranit Bauva, 2016-05-13 10:14 Subject: [PATCH] t6030: explicitly test for bisection cleanup Message-ID: <1463134469-26071-1-git-send-email-pranit.bauva@gmail.com> URL: https://gitlist.dev/e/1463134469-26071-1-git-send-email-pranit.bauva%40gmail.com ``` This is not an improvement in the test coverage but it helps in making it explicit as to know what exactly is the error as other tests are focussed on testing other things but they do indirectly test for this. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva --- I faced this problem while converting `bisect_clean_state` and the tests where showing breakages but it wasn't clear as to where exactly are they breaking. This will patch will help in that. Also I tested the test coverage of the test suite before this patch and it covers this (I did this by purposely changing names of files in git-bisect.sh and running the test suite). Signed-off-by: Pranit Bauva --- t/t6030-bisect-porcelain.sh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh index e74662b..1fb5ad9 100755 --- a/t/t6030-bisect-porcelain.sh +++ b/t/t6030-bisect-porcelain.sh @@ -894,4 +894,21 @@ test_expect_success 'bisect start takes options and revs in any order' ' test_cmp expected actual ' +test_expect_success 'git bisect reset cleans bisection state properly' ' + git bisect reset && + git bisect start && + git bisect good $HASH1 && + git bisect bad $HASH4 && + git bisect reset && + test -z "$(git for-each-ref "refs/bisect/*")" && + ! test -s "$GIT_DIR/BISECT_EXPECTED_REV" && + ! test -s "$GIT_DIR/BISECT_ANCESTORS_OK" && + ! test -s "$GIT_DIR/BISECT_LOG" && + ! test -s "$GIT_DIR/BISECT_RUN" && + ! test -s "$GIT_DIR/BISECT_TERMS" && + ! test -s "$GIT_DIR/head-name" && + ! test -s "$GIT_DIR/BISECT_HEAD" && + ! test -s "$GIT_DIR/BISECT_START" +' + test_done -- 2.8.2 ``` ## Pranit Bauva, 2016-05-27 17:57 Subject: Re: [PATCH] t6030: explicitly test for bisection cleanup Message-ID: URL: https://gitlist.dev/e/CAFZEwPMyts8msEgdHOiPfC-_HEXp8SJ7-8FQScr-af%3D5tSxq7w%40mail.gmail.com In-Reply-To: <1463134469-26071-1-git-send-email-pranit.bauva@gmail.com> ``` On Fri, May 13, 2016 at 3:44 PM, Pranit Bauva wrote: > This is not an improvement in the test coverage but it helps in making > it explicit as to know what exactly is the error as other tests are > focussed on testing other things but they do indirectly test for this. > > Mentored-by: Lars Schneider > Mentored-by: Christian Couder > Signed-off-by: Pranit Bauva > > --- > I faced this problem while converting `bisect_clean_state` and the tests > where showing breakages but it wasn't clear as to where exactly are they > breaking. This will patch will help in that. Also I tested the test > coverage of the test suite before this patch and it covers this (I did > this by purposely changing names of files in git-bisect.sh and running > the test suite). > > Signed-off-by: Pranit Bauva > --- > t/t6030-bisect-porcelain.sh | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh > index e74662b..1fb5ad9 100755 > --- a/t/t6030-bisect-porcelain.sh > +++ b/t/t6030-bisect-porcelain.sh > @@ -894,4 +894,21 @@ test_expect_success 'bisect start takes options and revs in any order' ' > test_cmp expected actual > ' > > +test_expect_success 'git bisect reset cleans bisection state properly' ' > + git bisect reset && > + git bisect start && > + git bisect good $HASH1 && > + git bisect bad $HASH4 && > + git bisect reset && > + test -z "$(git for-each-ref "refs/bisect/*")" && > + ! test -s "$GIT_DIR/BISECT_EXPECTED_REV" && > + ! test -s "$GIT_DIR/BISECT_ANCESTORS_OK" && > + ! test -s "$GIT_DIR/BISECT_LOG" && > + ! test -s "$GIT_DIR/BISECT_RUN" && > + ! test -s "$GIT_DIR/BISECT_TERMS" && > + ! test -s "$GIT_DIR/head-name" && > + ! test -s "$GIT_DIR/BISECT_HEAD" && > + ! test -s "$GIT_DIR/BISECT_START" > +' > + > test_done > -- > 2.8.2 > Anyone any comments? Regards, Pranit Bauva ``` ## Christian Couder, 2016-05-27 19:00 Subject: Re: [PATCH] t6030: explicitly test for bisection cleanup Message-ID: URL: https://gitlist.dev/e/CAP8UFD0NfUZa_SH7Q9WizV0%3D5DbjGq58sOU2COe5NSPSSn%3D%2B-Q%40mail.gmail.com In-Reply-To: ``` On Fri, May 27, 2016 at 7:57 PM, Pranit Bauva wrote: > > Anyone any comments? Maybe you could add this patch to, or squash it into, the patch that convert bisect_clean_state to C. Thanks, Christian. ``` ## Pranit Bauva, 2016-05-27 19:22 Subject: Re: [PATCH] t6030: explicitly test for bisection cleanup Message-ID: URL: https://gitlist.dev/e/CAFZEwPPMaCtG4VsJ31LKUP%3DmK_mqEekEPPrwDagyEUHHB0F2hQ%40mail.gmail.com In-Reply-To: ``` Hey Christian, On Sat, May 28, 2016 at 12:30 AM, Christian Couder wrote: > On Fri, May 27, 2016 at 7:57 PM, Pranit Bauva wrote: >> >> Anyone any comments? > > Maybe you could add this patch to, or squash it into, the patch that > convert bisect_clean_state to C. Sure! Regards, Pranit Bauva > Thanks, > Christian. ```