# [PATCH] gitweb: fix link to parent diff with pathinfo 8 messages from 2016-05-06 to 2016-05-25. Participants: Richard Braun, Junio C Hamano, Jakub Narębski. Thread: https://gitlist.dev/t/42235 ## Richard Braun, 2016-05-06 10:19 Subject: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: <1462529978-31322-1-git-send-email-rbraun@sceen.net> URL: https://gitlist.dev/e/1462529978-31322-1-git-send-email-rbraun%40sceen.net ``` Signed-off-by: Richard Braun --- gitweb/gitweb.perl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 05d7910..f7f7936 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1423,7 +1423,12 @@ sub href { delete $params{'hash'}; delete $params{'hash_base'}; } elsif (defined $params{'hash'}) { - $href .= esc_path_info($params{'hash'}); + if (defined $params{'hash_parent'}) { + $href .= esc_path_info($params{'hash_parent'}); + delete $params{'hash_parent'}; + } else { + $href .= esc_path_info($params{'hash'}); + } delete $params{'hash'}; } -- 2.1.4 ``` ## Junio C Hamano, 2016-05-06 22:21 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: URL: https://gitlist.dev/e/xmqqmvo225fg.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1462529978-31322-1-git-send-email-rbraun@sceen.net> ``` Richard Braun writes: > Signed-off-by: Richard Braun > --- Could you justify your change with a bit more than "fix"? That is, gitweb, when used with PATH_INFO, shows a link to parent diff like [fill in the blank]. However, it is wrong because [fill in the blank]. Make it show it like [fill in the blank]. Because [fill in the blank], delete 'hash_parent' element from the %params hash once we used it; otherwise [fill in the blank to describe "this bad thing happens"]. or something like that. Thanks. > gitweb/gitweb.perl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 05d7910..f7f7936 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -1423,7 +1423,12 @@ sub href { > delete $params{'hash'}; > delete $params{'hash_base'}; > } elsif (defined $params{'hash'}) { > - $href .= esc_path_info($params{'hash'}); > + if (defined $params{'hash_parent'}) { > + $href .= esc_path_info($params{'hash_parent'}); > + delete $params{'hash_parent'}; > + } else { > + $href .= esc_path_info($params{'hash'}); > + } > delete $params{'hash'}; > } ``` ## Richard Braun, 2016-05-07 00:11 Subject: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: <1462579902-18907-1-git-send-email-rbraun@sceen.net> URL: https://gitlist.dev/e/1462579902-18907-1-git-send-email-rbraun%40sceen.net In-Reply-To: ``` Gitweb, when used with PATH_INFO, shows a link to parent diff like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. That link reports "400 - Invalid hash parameter". As I understand it, it should instead directly point to the parent diff, i.e. turn it into http://somedomain/somerepo.git/commitdiff/parenthash, and delete 'hash_parent' element from the %params hash once we used it, otherwise the '?hp=parenthash' string is appended. Signed-off-by: Richard Braun --- gitweb/gitweb.perl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 05d7910..f7f7936 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1423,7 +1423,12 @@ sub href { delete $params{'hash'}; delete $params{'hash_base'}; } elsif (defined $params{'hash'}) { - $href .= esc_path_info($params{'hash'}); + if (defined $params{'hash_parent'}) { + $href .= esc_path_info($params{'hash_parent'}); + delete $params{'hash_parent'}; + } else { + $href .= esc_path_info($params{'hash'}); + } delete $params{'hash'}; } -- 2.1.4 ``` ## Junio C Hamano, 2016-05-24 18:17 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: URL: https://gitlist.dev/e/xmqq37p75nif.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1462579902-18907-1-git-send-email-rbraun@sceen.net> ``` Richard Braun writes: > Gitweb, when used with PATH_INFO, shows a link to parent diff > like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. > That link reports "400 - Invalid hash parameter". > > As I understand it, it should instead directly point to the parent diff, > i.e. turn it into http://somedomain/somerepo.git/commitdiff/parenthash, > and delete 'hash_parent' element from the %params hash once we used it, > otherwise the '?hp=parenthash' string is appended. > > Signed-off-by: Richard Braun > --- Pinging... > gitweb/gitweb.perl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 05d7910..f7f7936 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -1423,7 +1423,12 @@ sub href { > delete $params{'hash'}; > delete $params{'hash_base'}; > } elsif (defined $params{'hash'}) { > - $href .= esc_path_info($params{'hash'}); > + if (defined $params{'hash_parent'}) { > + $href .= esc_path_info($params{'hash_parent'}); > + delete $params{'hash_parent'}; > + } else { > + $href .= esc_path_info($params{'hash'}); > + } > delete $params{'hash'}; > } ``` ## Richard Braun, 2016-05-24 18:26 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: <20160524182623.GA8562@shattrath> URL: https://gitlist.dev/e/20160524182623.GA8562%40shattrath In-Reply-To: ``` On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote: > Pinging... Hum, see [1]. Tell me if I need to resend. -- Richard Braun Pacte Novation / Novasys Ingénierie [1] http://git.661346.n2.nabble.com/PATCH-gitweb-fix-link-to-parent-diff-with-pathinfo-td7655482.html ``` ## Junio C Hamano, 2016-05-24 18:39 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: URL: https://gitlist.dev/e/xmqqtwhn47xs.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20160524182623.GA8562@shattrath> ``` Richard Braun writes: > On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote: >> Pinging... > > Hum, see [1]. > > Tell me if I need to resend. Sorry, check the "To:" field of the message you are responding to. The ping was not meant to (and was not addressed to) you. It asked for comments from an area expert. ``` ## Jakub Narębski, 2016-05-25 20:33 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: URL: https://gitlist.dev/e/CANQwDwdKaVDGDxZZma25WcV%2Bea90YtFhDedLwv2KNZt6jhKVAQ%40mail.gmail.com In-Reply-To: ``` On Tue, May 24, 2016 at 8:17 PM, Junio C Hamano wrote: > Richard Braun writes: > >> Gitweb, when used with PATH_INFO, shows a link to parent diff >> like http://somedomain/somerepo.git/commitdiff/somehash?hp=parenthash. >> That link reports "400 - Invalid hash parameter". Richard, at which view is this bad link present? Err... never mind, I see that gitweb uses link to 'commitdiff' view with 'hash_parent' parameter set only ..in two places (well, perhaps there are some which get hash_parent from -replay, but I doubt it): the "commit" view (link to each parent commit) and in "commitdiff" view for octopus merges (e.g. "pu" in git.git). The problem is not with ?hp=parenthash, but with /somehash part, which somehow got invalid (from the error message). I have checked using http://repo.or.cz/git.git, and while it has the bug (i.e. uses '?hp=...' instead of path_info), there is no "400 - Invalid has parameter" error. >> As I understand it, it should instead directly point to the parent diff, >> i.e. turn it into http://somedomain/somerepo.git/commitdiff/parenthash, Actually, the correct path_info based URI would be http://somedomain/somerepo.git/commitdiff/parenthash..somehash Just like href() does with hash_parent_base and hash_base for blobdiff. Urgh... href() is a bit of mess, now I see it when I am not current. >> and delete 'hash_parent' element from the %params hash once we used it, >> otherwise the '?hp=parenthash' string is appended. That's correct: the unstated rule of href is that if it went into path_info, it is deleted (not everything can be expressed with path_info), the rest goes into query parameters. So without deleting the element, it would be duplicated. Note that using query parameter when we can use path_info is a minor error; URL should work anyway (and I don't see why it doesn't - somewhat the 'hash' parameter got incorrect...). >> >> Signed-off-by: Richard Braun >> --- > > Pinging... I'm sorry, I didn't notice it was meant for me. Simple "Jakub,..." would be enough. On Tue, May 24, 2016 at 8:39 PM, Junio C Hamano wrote: > Richard Braun writes: > >> On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote: >>> Pinging... >> >> Hum, see [1]. >> >> Tell me if I need to resend. > > Sorry, check the "To:" field of the message you are responding to. > The ping was not meant to (and was not addressed to) you. It asked > for comments from an area expert. Only this made me realize that you are expecting *my* response. >> gitweb/gitweb.perl | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl >> index 05d7910..f7f7936 100755 >> --- a/gitweb/gitweb.perl >> +++ b/gitweb/gitweb.perl >> @@ -1423,7 +1423,12 @@ sub href { >> delete $params{'hash'}; >> delete $params{'hash_base'}; >> } elsif (defined $params{'hash'}) { >> - $href .= esc_path_info($params{'hash'}); >> + if (defined $params{'hash_parent'}) { >> + $href .= esc_path_info($params{'hash_parent'}); >> + delete $params{'hash_parent'}; >> + } else { >> + $href .= esc_path_info($params{'hash'}); >> + } This should read _something_ like this + if (defined $params{'hash_parent'}) { + $href .= esc_path_info($params{'hash_parent'}) . '..'; + delete $params{'hash_parent'}; + } + $href .= esc_path_info($params{'hash'}); + delete $params{'hash'}; Otherwise you would get correct link in your situation with bad 'hash' parameter, but not the view that was requested; it would not be diff between current and given parent, but commitdiff for parent (to grandparent(s)). Richard, thanks for finding a problematic thing, but you need to search more for a true fix. Regards -- Jakub Narebski ``` ## Richard Braun, 2016-05-25 22:20 Subject: Re: [PATCH] gitweb: fix link to parent diff with pathinfo Message-ID: <20160525222032.GA18076@shattrath> URL: https://gitlist.dev/e/20160525222032.GA18076%40shattrath In-Reply-To: ``` On Wed, May 25, 2016 at 10:33:32PM +0200, Jakub Narębski wrote: > Richard, thanks for finding a problematic thing, but you > need to search more for a true fix. Noted, I'll get back to you soon (hopefully not too late). -- Richard Braun ```