# [PATCH] t9824: fix wrong reference value 4 messages from 2016-04-29 to 2016-04-29. Participants: Lars Schneider, Junio C Hamano, Luke Diamand. Thread: https://gitlist.dev/t/42179 ## Lars Schneider, 2016-04-29 15:57 Subject: [PATCH] t9824: fix wrong reference value Message-ID: <0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000@eu-west-1.amazonses.com> URL: https://gitlist.dev/e/0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000%40eu-west-1.amazonses.com ``` 0492eb4 fixed a broken &&-chain in this test which broke the test as it checked for a wrong size. The expected size of the file under test is 39 bytes. The test checked that the size is 13 bytes. Fix the reference value to make the test pass, again. Signed-off-by: Lars Schneider --- t/t9824-git-p4-git-lfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh index 64f8d18..3fc6790 100755 --- a/t/t9824-git-p4-git-lfs.sh +++ b/t/t9824-git-p4-git-lfs.sh @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr # We only import HEAD here ("@all" is missing!) git p4 clone --destination="$git" //depot && - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && test_file_count_in_dir ".git/lfs/objects" 1 && cat >expect <<-\EOF && -- https://github.com/git/git/pull/235 ``` ## Junio C Hamano, 2016-04-29 17:34 Subject: Re: [PATCH] t9824: fix wrong reference value Message-ID: URL: https://gitlist.dev/e/xmqqmvocz5d6.fsf%40gitster.mtv.corp.google.com In-Reply-To: <0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000@eu-west-1.amazonses.com> ``` Lars Schneider writes: > 0492eb4 fixed a broken &&-chain in this test which broke the test as it > checked for a wrong size. The expected size of the file under test is > 39 bytes. The test checked that the size is 13 bytes. Fix the reference > value to make the test pass, again. > > Signed-off-by: Lars Schneider > --- That breaking "fix" seems to have been acked by you. It was sort of clear that SZEDER didn't actually ran the test from the patch, saying "As far as I can tell after eyeballing the test script,", but you obviously didn't actually have a chance to test it until now. Thanks for fixing it before it hits 'master'; this time I think it is safe to assume that this was actually tested ;-) > t/t9824-git-p4-git-lfs.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh > index 64f8d18..3fc6790 100755 > --- a/t/t9824-git-p4-git-lfs.sh > +++ b/t/t9824-git-p4-git-lfs.sh > @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr > # We only import HEAD here ("@all" is missing!) > git p4 clone --destination="$git" //depot && > > - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && > + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && > test_file_count_in_dir ".git/lfs/objects" 1 && > > cat >expect <<-\EOF && > > -- > https://github.com/git/git/pull/235 ``` ## Lars Schneider, 2016-04-29 20:29 Subject: Re: [PATCH] t9824: fix wrong reference value Message-ID: URL: https://gitlist.dev/e/ACC53CBE-D83A-49E9-9DC7-C99F485D3E55%40gmail.com In-Reply-To: ``` On 29 Apr 2016, at 19:34, Junio C Hamano wrote: > Lars Schneider writes: > >> 0492eb4 fixed a broken &&-chain in this test which broke the test as it >> checked for a wrong size. The expected size of the file under test is >> 39 bytes. The test checked that the size is 13 bytes. Fix the reference >> value to make the test pass, again. >> >> Signed-off-by: Lars Schneider >> --- > > That breaking "fix" seems to have been acked by you. > > It was sort of clear that SZEDER didn't actually ran the test from > the patch, saying "As far as I can tell after eyeballing the test > script,", but you obviously didn't actually have a chance to test it > until now. > > Thanks for fixing it before it hits 'master'; this time I think it > is safe to assume that this was actually tested ;-) Yes! Lesson learned! Sorry Szeder! - Lars > > >> t/t9824-git-p4-git-lfs.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh >> index 64f8d18..3fc6790 100755 >> --- a/t/t9824-git-p4-git-lfs.sh >> +++ b/t/t9824-git-p4-git-lfs.sh >> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr >> # We only import HEAD here ("@all" is missing!) >> git p4 clone --destination="$git" //depot && >> >> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && >> + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" && >> test_file_count_in_dir ".git/lfs/objects" 1 && >> >> cat >expect <<-\EOF && >> >> -- >> https://github.com/git/git/pull/235 ``` ## Luke Diamand, 2016-04-29 20:40 Subject: Re: [PATCH] t9824: fix wrong reference value Message-ID: URL: https://gitlist.dev/e/CAE5ih7-AZCoJp2tO2KWRO4A9mWhdsNb_QTew93CmFCRh9kmATw%40mail.gmail.com In-Reply-To: ``` On 29 April 2016 at 21:29, Lars Schneider wrote: > > On 29 Apr 2016, at 19:34, Junio C Hamano wrote: > >> Lars Schneider writes: >> >>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it >>> checked for a wrong size. The expected size of the file under test is >>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference >>> value to make the test pass, again. >>> >>> Signed-off-by: Lars Schneider >>> --- >> >> That breaking "fix" seems to have been acked by you. >> >> It was sort of clear that SZEDER didn't actually ran the test from >> the patch, saying "As far as I can tell after eyeballing the test >> script,", but you obviously didn't actually have a chance to test it >> until now. >> >> Thanks for fixing it before it hits 'master'; this time I think it >> is safe to assume that this was actually tested ;-) > > Yes! Lesson learned! Sorry Szeder! How does the old saying go? If it hasn't been tested, it doesn't work! Luke ```