# [PATCH] tag.c: remove extern keyword from function definition 2 messages from 2016-04-20 to 2016-04-20. Participants: Ramsay Jones, Santiago Torres. Thread: https://gitlist.dev/t/42088 ## Ramsay Jones, 2016-04-20 15:34 Subject: [PATCH] tag.c: remove extern keyword from function definition Message-ID: <5717A181.1000603@ramsayjones.plus.com> URL: https://gitlist.dev/e/5717A181.1000603%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Santiago, If you need to re-roll your 'st/verify-tag' branch, could you please squash this into the relevant patch (commit c5213b40, "verify-tag: move tag verification code to tag.c", 19-04-2016). Although not actually an error, it is very unusual for an extern keyword to be used on a function definition (it seems to be getting quite unusual on a function declaration these days!), which causes sparse to issue a warning. Thanks! ATB, Ramsay Jones tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tag.c b/tag.c index ace619a..93c6ae6 100644 --- a/tag.c +++ b/tag.c @@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags) return ret; } -extern int gpg_verify_tag(const unsigned char *sha1, +int gpg_verify_tag(const unsigned char *sha1, const char *name_to_report, unsigned flags) { enum object_type type; -- 2.8.0 ``` ## Santiago Torres, 2016-04-20 15:39 Subject: Re: [PATCH] tag.c: remove extern keyword from function definition Message-ID: <20160420153928.GA1314@LykOS> URL: https://gitlist.dev/e/20160420153928.GA1314%40LykOS In-Reply-To: <5717A181.1000603@ramsayjones.plus.com> ``` On Wed, Apr 20, 2016 at 04:34:25PM +0100, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Santiago, > > If you need to re-roll your 'st/verify-tag' branch, could you > please squash this into the relevant patch (commit c5213b40, > "verify-tag: move tag verification code to tag.c", 19-04-2016). > > Although not actually an error, it is very unusual for an extern > keyword to be used on a function definition (it seems to be getting > quite unusual on a function declaration these days!), which causes > sparse to issue a warning. Oh sure! I'm waiting to see if there are more reviews regarding this and I'll re-roll. It's defintely unecessary to have the extern keyword there. Thanks for pointing it out! -Santiago. ```