threads / patch / 4207

patch, 5 partsCorrect force_write bug in refs.c

Subject: [PATCH 1/5] Correct force_write bug in refs.c

## tl;dr

One message between May 19, 2006 and May 19, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn Pearce· May 19, 2006, 09:15 UTC · lore

My earlier attempt at forcing a write for non-existant refs worked; it forced a write for pretty much all refs. This corrects the condition to only force a write for refs which don't exist yet.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 refs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
5ee16115982c52fa9b8fa15c14b234608a8b935d
Show changes to refs.c +1 −1
diff --git a/refs.c b/refs.c
index d3ddc82..eeb1196 100644
--- a/refs.c
+++ b/refs.c
@@ -305,7 +305,7 @@ static struct ref_lock* lock_ref_sha1_ba
 	lock->ref_file = strdup(path);
 	lock->lock_file = strdup(mkpath("%s.lock", lock->ref_file));
 	lock->log_file = strdup(git_path("logs/%s", lock->ref_file + plen));
-	lock->force_write = !lstat(lock->ref_file, &st) || errno == ENOENT;
+	lock->force_write = lstat(lock->ref_file, &st) && errno == ENOENT;
 
 	if (safe_create_leading_directories(lock->lock_file))
 		die("unable to create directory for %s", lock->lock_file);
-- 
1.3.2.g7278

← back to recent threads