# [PATCH] There was a little inconsistancy in git prompt

2 messages from 2016-04-12 to 2016-04-12. Participants: Rudy YAYON, Todd Zullinger.
Thread: https://gitlist.dev/t/41999

## Rudy YAYON, 2016-04-12 07:16

Subject: [PATCH] There was a little inconsistancy in git prompt
Message-ID: <01020154095436db-40246224-5586-4e95-b5f7-59b27928ffa8-000000@eu-west-1.amazonses.com>
URL: https://gitlist.dev/e/01020154095436db-40246224-5586-4e95-b5f7-59b27928ffa8-000000%40eu-west-1.amazonses.com

```
---
 contrib/completion/git-prompt.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh
index 07b52be..18be99f 100644
--- a/contrib/completion/git-prompt.sh
+++ b/contrib/completion/git-prompt.sh
@@ -194,13 +194,13 @@ __git_ps1_show_upstream ()
 		"") # no upstream
 			p="" ;;
 		"0	0") # equal to upstream
-			p="=" ;;
+			p=" =" ;;
 		"0	"*) # ahead of upstream
-			p=">" ;;
+			p=" >" ;;
 		*"	0") # behind upstream
-			p="<" ;;
+			p=" <" ;;
 		*)	    # diverged from upstream
-			p="<>" ;;
+			p=" <>" ;;
 		esac
 	else
 		case "$count" in

--
https://github.com/git/git/pull/181

```

## Todd Zullinger, 2016-04-12 15:27

Subject: Re: [PATCH] There was a little inconsistancy in git prompt
Message-ID: <20160412152739.GL15513@zaya.teonanacatl.net>
URL: https://gitlist.dev/e/20160412152739.GL15513%40zaya.teonanacatl.net
In-Reply-To: <01020154095436db-40246224-5586-4e95-b5f7-59b27928ffa8-000000@eu-west-1.amazonses.com>

```
Hi Rudy,

I think the commit subject should include a bit more detail.  Ideally, 
the subject would start with 'bash prompt: ' to make it clear what 
area the commit involves.  Then you would want to describe what 
inconsistency is being fixed (and why).

Rudy YAYON wrote:
> ---
> contrib/completion/git-prompt.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh
> index 07b52be..18be99f 100644
> --- a/contrib/completion/git-prompt.sh
> +++ b/contrib/completion/git-prompt.sh
> @@ -194,13 +194,13 @@ __git_ps1_show_upstream ()
> 		"") # no upstream
> 			p="" ;;
> 		"0	0") # equal to upstream
> -			p="=" ;;
> +			p=" =" ;;
> 		"0	"*) # ahead of upstream
> -			p=">" ;;
> +			p=" >" ;;
> 		*"	0") # behind upstream
> -			p="<" ;;
> +			p=" <" ;;
> 		*)	    # diverged from upstream
> -			p="<>" ;;
> +			p=" <>" ;;
> 		esac
> 	else
> 		case "$count" in

I attempted to solve this a while back (longer than I realized, now 
that I found the previous thread):

http://thread.gmane.org/gmane.comp.version-control.git/169330

Junio had some comments and suggestions, which I lacked time to follow 
up on, it appears. (I thought there was more discussion but it must 
have all been in my head. ;)

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When I think about all the crap I learned in high school ... it's a
wonder I can think at all.
    -- Paul Simon

```