# [PATCH 2/3] index-helper: convert strncpy to memcpy 2 messages from 2016-04-10 to 2016-04-11. Participants: Ramsay Jones, David Turner. Thread: https://gitlist.dev/t/41985 ## Ramsay Jones, 2016-04-10 23:02 Subject: [PATCH 2/3] index-helper: convert strncpy to memcpy Message-ID: <570ADB68.8000705@ramsayjones.plus.com> URL: https://gitlist.dev/e/570ADB68.8000705%40ramsayjones.plus.com ``` see commit eddda371 ("convert strncpy to memcpy", 24-09-2015). Signed-off-by: Ramsay Jones --- index-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index-helper.c b/index-helper.c index 4a8e2ae..00f286a 100644 --- a/index-helper.c +++ b/index-helper.c @@ -317,7 +317,7 @@ static int setup_socket(const char *socket_path) return -1; address.sun_family = AF_UNIX; - strncpy(address.sun_path, socket_path, sizeof(address.sun_path)); + memcpy(address.sun_path, socket_path, len+1); /* include '\0' */ if (bind(fd, (struct sockaddr *) &address, sizeof(address))) die_errno(_("failed to bind to socket %s"), socket_path); -- 2.8.0 ``` ## David Turner, 2016-04-11 22:30 Subject: Re: [PATCH 2/3] index-helper: convert strncpy to memcpy Message-ID: <1460413854.5540.24.camel@twopensource.com> URL: https://gitlist.dev/e/1460413854.5540.24.camel%40twopensource.com In-Reply-To: <570ADB68.8000705@ramsayjones.plus.com> ``` On Mon, 2016-04-11 at 00:02 +0100, Ramsay Jones wrote: > see commit eddda371 ("convert strncpy to memcpy", 24-09-2015). > > Signed-off-by: Ramsay Jones > --- > index-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/index-helper.c b/index-helper.c > index 4a8e2ae..00f286a 100644 > --- a/index-helper.c > +++ b/index-helper.c > @@ -317,7 +317,7 @@ static int setup_socket(const char *socket_path) > return -1; > > address.sun_family = AF_UNIX; > - strncpy(address.sun_path, socket_path, > sizeof(address.sun_path)); > + memcpy(address.sun_path, socket_path, len+1); /* include > '\0' */ > > if (bind(fd, (struct sockaddr *) &address, sizeof(address))) > die_errno(_("failed to bind to socket %s"), > socket_path); Thanks. I'm actually going to drop this patch because I'm switching to the unix -socket.c helpers, so the affected code no longer exists. But I appreciate the thought anyway. ```