threads / patch / 41966

patch, 2 partsimap-send: fixes for CRAM-MD5 authentication

Subject: [PATCH 0/2] imap-send: fixes for CRAM-MD5 authentication

## tl;dr

2 messages between Apr 8, 2016 and Apr 9, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Kazuki Yamaguchi· Apr 8, 2016, 14:02 UTC · lore

[1/2] Check for LOGINDISABLED capability only when using LOGIN command, as it is unrelated to authentication with CRAM-MD5.

[2/2] Remove extra + 1, which is probably mistakenly added. Without this patch I can't open my IMAP server (Dovecot 2.2).

Thanks,
Kazuki Yamaguchi (2):
  imap-send: check for NOLOGIN capability only when using LOGIN command
  imap-send: fix CRAM-MD5 response calculation
 imap-send.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
-- 
2.8.1.104.g07d5700.dirty
Hitoshi Mitake· Apr 9, 2016, 06:29 UTC · re: Kazuki Yamaguchi · lore

Re: [PATCH 0/2] imap-send: fixes for CRAM-MD5 authentication

At Fri, 8 Apr 2016 23:02:18 +0900, Kazuki Yamaguchi wrote:

Show 17 quoted lines
> 
> [1/2]
> Check for LOGINDISABLED capability only when using LOGIN command, as it
> is unrelated to authentication with CRAM-MD5.
> 
> [2/2]
> Remove extra + 1, which is probably mistakenly added. Without this patch
> I can't open my IMAP server (Dovecot 2.2).
> 
> Thanks,
> 
> Kazuki Yamaguchi (2):
>   imap-send: check for NOLOGIN capability only when using LOGIN command
>   imap-send: fix CRAM-MD5 response calculation
> 
>  imap-send.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Yamaguchi-san, thanks for your patches and letting me know. The CRAM-MD5 feature would have problems as you pointed. I just implemented it for my own usecase years ago (at that time I used Cyrus) and am not using it for now. The code is old but not tested well yet (I'm not sure how many people are using it).

Unfortunately I can't test the patches because I don't have an IMAP server that is suitable for testing. But I think the patches are worth to apply because they are valuable for your usecase. Sorry for my irresponible answer :(

← back to recent threads