# [PATCH] send-email: do not load Data::Dumper 2 messages from 2016-04-06 to 2016-04-06. Participants: Eric Wong, Jonathan Nieder. Thread: https://gitlist.dev/t/41947 ## Eric Wong, 2016-04-06 20:25 Subject: [PATCH] send-email: do not load Data::Dumper Message-ID: <20160406202538.GA27651@dcvr.yhbt.net> URL: https://gitlist.dev/e/20160406202538.GA27651%40dcvr.yhbt.net ``` We never used Data::Dumper in this script. The only reference of it was always commented out and removed over a decade ago in commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b ("send-email: Change from Mail::Sendmail to Net::SMTP") Signed-off-by: Eric Wong --- While I'm in the area... git-send-email.perl | 1 - 1 file changed, 1 deletion(-) diff --git a/git-send-email.perl b/git-send-email.perl index 52cf828..38f0a7e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -23,7 +23,6 @@ use POSIX qw/strftime/; use Term::ReadLine; use Getopt::Long; use Text::ParseWords; -use Data::Dumper; use Term::ANSIColor; use File::Temp qw/ tempdir tempfile /; use File::Spec::Functions qw(catfile); -- EW ``` ## Jonathan Nieder, 2016-04-06 21:07 Subject: Re: [PATCH] send-email: do not load Data::Dumper Message-ID: <20160406210706.GK28749@google.com> URL: https://gitlist.dev/e/20160406210706.GK28749%40google.com In-Reply-To: <20160406202538.GA27651@dcvr.yhbt.net> ``` Eric Wong wrote: > We never used Data::Dumper in this script. The only reference > of it was always commented out and removed over a decade ago in > commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b > ("send-email: Change from Mail::Sendmail to Net::SMTP") > > Signed-off-by: Eric Wong > --- > While I'm in the area... > > git-send-email.perl | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Jonathan Nieder Thanks. ```