# [PATCH] comment for a long #ifdef

4 messages from 2016-04-04 to 2016-04-04. Participants: Ivan Pozdeev, Eric Sunshine, Junio C Hamano.
Thread: https://gitlist.dev/t/41916

## Ivan Pozdeev, 2016-04-04 01:00

Subject: [PATCH] comment for a long #ifdef
Message-ID: <5701BCC1.9050306@mail.mipt.ru>
URL: https://gitlist.dev/e/5701BCC1.9050306%40mail.mipt.ru

```
---
compat/poll/poll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index db4e03e..5eb0280 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
}

return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}

return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}
-- 
1.9.5.msysgit.1


-- 
Regards,
Ivan

```

## Eric Sunshine, 2016-04-04 01:54

Subject: Re: [PATCH] comment for a long #ifdef
Message-ID: <CAPig+cS=oGvs3zWA782APy7moo3N-4-Oe9B8obej5oWKxw9Gsg@mail.gmail.com>
URL: https://gitlist.dev/e/CAPig%2BcS%3DoGvs3zWA782APy7moo3N-4-Oe9B8obej5oWKxw9Gsg%40mail.gmail.com
In-Reply-To: <5701BCC1.9050306@mail.mipt.ru>

```
On Sun, Apr 3, 2016 at 9:00 PM, Ivan Pozdeev <vano@mail.mipt.ru> wrote:
> ---

Missing sign-off. See Documentation/SubmittingPatches.

> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }

```

## Ivan Pozdeev, 2016-04-04 17:23

Subject: Re: [PATCH] comment for a long #ifdef
Message-ID: <5702A319.9030708@mail.mipt.ru>
URL: https://gitlist.dev/e/5702A319.9030708%40mail.mipt.ru
In-Reply-To: <CAPig+cS=oGvs3zWA782APy7moo3N-4-Oe9B8obej5oWKxw9Gsg@mail.gmail.com>

```
Signed-off-by: Ivan Pozdeev
---
compat/poll/poll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index db4e03e..5eb0280 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
}

return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}

return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}
-- 
1.9.5.msysgit.1


-- 
Regards,
Ivan

```

## Junio C Hamano, 2016-04-04 17:54

Subject: Re: [PATCH] comment for a long #ifdef
Message-ID: <xmqq4mbh5kfp.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqq4mbh5kfp.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <5701BCC1.9050306@mail.mipt.ru>

```
Ivan Pozdeev <vano@mail.mipt.ru> writes:

> ---
> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

As Eric pointed out, please sign-off your patch.

> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }
> -- 
> 1.9.5.msysgit.1

There also is an #ifndef/#else/#endif in abspath.c that is larger
than a typical patch context; could you include a fix for that, too?

```