# [RFC 1/5] Remove unnecessary local in get_ref_sha1.

2 messages from 2006-05-17 to 2006-05-17. Participants: Shawn Pearce, Junio C Hamano.
Thread: https://gitlist.dev/t/4177

## Shawn Pearce, 2006-05-17 09:54

Subject: [RFC 1/5] Remove unnecessary local in get_ref_sha1.
Message-ID: <20060517095446.GB28529@spearce.org>
URL: https://gitlist.dev/e/20060517095446.GB28529%40spearce.org

```
Remove unnecessary local in get_ref_sha1.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

---

 refs.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

339dddea51656af46f6c8a2fba7f50d96ae2a434
diff --git a/refs.c b/refs.c
index 6c91ae6..0f3491f 100644
--- a/refs.c
+++ b/refs.c
@@ -220,12 +220,9 @@ static char *ref_lock_file_name(const ch
 
 int get_ref_sha1(const char *ref, unsigned char *sha1)
 {
-	const char *filename;
-
 	if (check_ref_format(ref))
 		return -1;
-	filename = git_path("refs/%s", ref);
-	return read_ref(filename, sha1);
+	return read_ref(git_path("refs/%s", ref), sha1);
 }
 
 static int lock_ref_file(const char *filename, const char *lock_filename,
-- 
1.3.2.g7278

```

## Junio C Hamano, 2006-05-17 10:43

Subject: Re: [RFC 1/5] Remove unnecessary local in get_ref_sha1.
Message-ID: <7vr72tgcea.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vr72tgcea.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20060517095446.GB28529@spearce.org>

```
Shawn Pearce <spearce@spearce.org> writes:

> Remove unnecessary local in get_ref_sha1.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Ack.

```