# [PATCH] SubmittingPatches : WIP tag in patches 5 messages from 2016-02-26 to 2016-02-26. Participants: Pranit Bauva, Eric Sunshine, Stefan Tatschner. Thread: https://gitlist.dev/t/41530 ## Eric Sunshine, 2016-02-26 08:00 Subject: Re: [PATCH] SubmittingPatches : WIP tag in patches Message-ID: URL: https://gitlist.dev/e/CAPig%2BcT9Aqm0%2BAEGz0F-CTihMJtMw45fq4h6zxKs_7uxHak0bg%40mail.gmail.com In-Reply-To: <56D05BA2.1090502@zoho.com> ``` On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote: > --- Missing sign-off. > diff --git a/Documentation/SubmittingPatches > @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch > is also > encouraged. E.g. [PATCH/RFC] is often used when the patch is > not ready to be applied but it is for discussion, [PATCH v2], > [PATCH v3] etc. are often seen when you are sending an update to > -what you have previously sent. > +what you have previously sent. [PATCH/WIP] is often used when some Perhaps: /is often/can be/ > +work is yet left to be done on the patch but you want to get the > +review on the completed part of the patch. Maybe: s/review/feedback/ > "git format-patch" command follows the best current practice to > format the body of an e-mail message. At the beginning of the > -- > 2.1.4 ``` ## Eric Sunshine, 2016-02-26 08:19 Subject: Re: [PATCH] SubmittingPatches : WIP tag in patches Message-ID: URL: https://gitlist.dev/e/CAPig%2BcTmUo_9Ji%2B73EiEXibjy%3DkN7w6bhFYraBNdhc1nO7D0pg%40mail.gmail.com In-Reply-To: <56D05EE9.8020400@zoho.com> ``` On Fri, Feb 26, 2016 at 9:19 AM, Pranit Bauva wrote: > Eric Sunshine: >> On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote: >>> --- >> Missing sign-off. > > I have to inoculate the habit of signing off every time. >>> diff --git a/Documentation/SubmittingPatches >>> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch >>> is also >>> encouraged. E.g. [PATCH/RFC] is often used when the patch is >>> not ready to be applied but it is for discussion, [PATCH v2], >>> [PATCH v3] etc. are often seen when you are sending an update to >>> -what you have previously sent. >>> +what you have previously sent. [PATCH/WIP] is often used when some >> >> Perhaps: /is often/can be/ >> >>> +work is yet left to be done on the patch but you want to get the >>> +review on the completed part of the patch. >> >> Maybe: s/review/feedback/ >> >>> "git format-patch" command follows the best current practice to >>> format the body of an e-mail message. At the beginning of the >>> -- >>> 2.1.4 > > I have done the required changes, now I should send another email with > tag [PATCH v2] right? Yes, you can do that, or wait a bit longer for feedback from other reviewers. It's also a good idea in the commentary section to say what changed between v1 and v2, and, as an aid to reviewers, provide a link like this[1] to the previous version. [1]: http://thread.gmane.org/gmane.comp.version-control.git/287544 ``` ## Stefan Tatschner, 2016-02-26 08:19 Subject: Re: [PATCH] SubmittingPatches : WIP tag in patches Message-ID: <56D00AA6.4060302@sevenbyte.org> URL: https://gitlist.dev/e/56D00AA6.4060302%40sevenbyte.org In-Reply-To: <56D05EE9.8020400@zoho.com> ``` On 26.02.2016 15:19, Pranit Bauva wrote: > I have to inoculate the habit of signing off every time. There is this in git-config(1); hope that helps. format.signOff A boolean value which lets you enable the -s/--signoff option of format-patch by default. Note: Adding the Signed-off-by: line to a patch should be a conscious act and means that you certify you have the rights to submit this work under the same open source license. Please see the SubmittingPatches document for further discussion. Stefan ``` ## Pranit Bauva, 2016-02-26 14:05 Subject: [PATCH] SubmittingPatches : WIP tag in patches Message-ID: <56D05BA2.1090502@zoho.com> URL: https://gitlist.dev/e/56D05BA2.1090502%40zoho.com ``` --- Documentation/SubmittingPatches | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 98fc4cc..b2c7664 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch is also encouraged. E.g. [PATCH/RFC] is often used when the patch is not ready to be applied but it is for discussion, [PATCH v2], [PATCH v3] etc. are often seen when you are sending an update to -what you have previously sent. +what you have previously sent. [PATCH/WIP] is often used when some +work is yet left to be done on the patch but you want to get the +review on the completed part of the patch. "git format-patch" command follows the best current practice to format the body of an e-mail message. At the beginning of the -- 2.1.4 ``` ## Pranit Bauva, 2016-02-26 14:19 Subject: Re: [PATCH] SubmittingPatches : WIP tag in patches Message-ID: <56D05EE9.8020400@zoho.com> URL: https://gitlist.dev/e/56D05EE9.8020400%40zoho.com In-Reply-To: ``` Eric Sunshine: > On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote: >> --- > > Missing sign-off. > I have to inoculate the habit of signing off every time. >> diff --git a/Documentation/SubmittingPatches >> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch >> is also >> encouraged. E.g. [PATCH/RFC] is often used when the patch is >> not ready to be applied but it is for discussion, [PATCH v2], >> [PATCH v3] etc. are often seen when you are sending an update to >> -what you have previously sent. >> +what you have previously sent. [PATCH/WIP] is often used when some > > Perhaps: /is often/can be/ > >> +work is yet left to be done on the patch but you want to get the >> +review on the completed part of the patch. > > Maybe: s/review/feedback/ > >> "git format-patch" command follows the best current practice to >> format the body of an e-mail message. At the beginning of the >> -- >> 2.1.4 I have done the required changes, now I should send another email with tag [PATCH v2] right? ```