# [PATCH] gitk: Follow themed bgcolor in help dialogs

2 messages from 2016-02-04 to 2016-03-19. Participants: Guillermo S. Romero, Paul Mackerras.
Thread: https://gitlist.dev/t/41324

## Guillermo S. Romero, 2016-02-04 02:32

Subject: [PATCH] gitk: Follow themed bgcolor in help dialogs
Message-ID: <20160204023219.GA27647@fortress.battleship>
URL: https://gitlist.dev/e/20160204023219.GA27647%40fortress.battleship

```
Make Help > About & Key bindings dialogs readable if theme
has changed font color to something incompatible with white.

Signed-off-by: Guillermo S. Romero <gsromero@infernal-iceberg.com>
---

Hi:

Found more places where themable colors makes things unreadable
because not everything adapted to the changed style.

GSR
 
PS: Not subscribed to git@vger, so remember to CC: me.
 

 gitk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gitk b/gitk
index 5f1255c..805a1c7 100755
--- a/gitk
+++ b/gitk
@@ -3021,7 +3021,7 @@ proc bindall {event action} {
 }
 
 proc about {} {
-    global uifont NS
+    global bgcolor NS
     set w .about
     if {[winfo exists $w]} {
 	raise $w
@@ -3036,7 +3036,7 @@ Gitk - a commit viewer for git
 Copyright \u00a9 2005-2014 Paul Mackerras
 
 Use and redistribute under the terms of the GNU General Public License"] \
-	    -justify center -aspect 400 -border 2 -bg white -relief groove
+	    -justify center -aspect 400 -border 2 -bg $bgcolor -relief groove
     pack $w.m -side top -fill x -padx 2 -pady 2
     ${NS}::button $w.ok -text [mc "Close"] -command "destroy $w" -default active
     pack $w.ok -side bottom
@@ -3047,7 +3047,7 @@ Use and redistribute under the terms of the GNU General Public License"] \
 }
 
 proc keys {} {
-    global NS
+    global bgcolor NS
     set w .keys
     if {[winfo exists $w]} {
 	raise $w
@@ -3103,7 +3103,7 @@ proc keys {} {
 [mc "<%s-minus>	Decrease font size" $M1T]
 [mc "<F5>		Update"]
 " \
-	    -justify left -bg white -border 2 -relief groove
+	    -justify left -bg $bgcolor -border 2 -relief groove
     pack $w.m -side top -fill both -padx 2 -pady 2
     ${NS}::button $w.ok -text [mc "Close"] -command "destroy $w" -default active
     bind $w <Key-Escape> [list destroy $w]
-- 
2.7.0.rc3

```

## Paul Mackerras, 2016-03-19 06:57

Subject: Re: [PATCH] gitk: Follow themed bgcolor in help dialogs
Message-ID: <20160319065715.GF27126@fergus.ozlabs.ibm.com>
URL: https://gitlist.dev/e/20160319065715.GF27126%40fergus.ozlabs.ibm.com
In-Reply-To: <20160204023219.GA27647@fortress.battleship>

```
On Thu, Feb 04, 2016 at 03:32:19AM +0100, Guillermo S. Romero wrote:
> Make Help > About & Key bindings dialogs readable if theme
> has changed font color to something incompatible with white.
> 
> Signed-off-by: Guillermo S. Romero <gsromero@infernal-iceberg.com>

Thanks, applied.
Paul.

```