# [PATCH] Ensure author information is set before asking for commit message.

3 messages from 2006-05-14 to 2006-05-14. Participants: Sean, Junio C Hamano.
Thread: https://gitlist.dev/t/4130

## Sean, 2006-05-14 01:51

Subject: [PATCH] Ensure author information is set before asking for commit message.
Message-ID: <BAYC1-PASMTP10DC791E7560155D9E71F4AEA20@CEZ.ICE>
URL: https://gitlist.dev/e/BAYC1-PASMTP10DC791E7560155D9E71F4AEA20%40CEZ.ICE

```
It's better to find out you need to set your author information
properly before you enter a long commit message.

Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>

---

 git-commit.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

ae880db6fc12a0774c25925abbcc353fe6c9e46f
diff --git a/git-commit.sh b/git-commit.sh
index 26cd7ca..866ed6c 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -640,6 +640,7 @@ case "$no_edit" in
 		exit 1
 		;;
 	esac
+	git-var GIT_AUTHOR_IDENT > /dev/null  || die
 	${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"
 	;;
 esac
-- 
1.3.2.g260bd

```

## Junio C Hamano, 2006-05-14 02:41

Subject: Re: [PATCH] Ensure author information is set before asking for commit message.
Message-ID: <7vlkt5s4yw.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vlkt5s4yw.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <BAYC1-PASMTP10DC791E7560155D9E71F4AEA20@CEZ.ICE>

```
Sean <seanlkml@sympatico.ca> writes:

> It's better to find out you need to set your author information
> properly before you enter a long commit message.
>
> Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>

Makes sense but I suspect you would want COMMITTER not AUTHOR.
Imagine you pulled from somewhere else and it conflicted,
requiring you to hand resolve and then run git-commit.

```

## Sean, 2006-05-14 03:09

Subject: [PATCH] Ensure author & committer before asking for commit message.
Message-ID: <BAYC1-PASMTP06C5870DB0764F7F3284A3AEA20@CEZ.ICE>
URL: https://gitlist.dev/e/BAYC1-PASMTP06C5870DB0764F7F3284A3AEA20%40CEZ.ICE
In-Reply-To: <7vlkt5s4yw.fsf@assigned-by-dhcp.cox.net>

```

It's better to find out you need to fix your author and
committer information before you enter a long commit message.

Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>

---

On Sat, 13 May 2006 19:41:27 -0700
Junio C Hamano <junkio@cox.net> wrote:

> Makes sense but I suspect you would want COMMITTER not AUTHOR.
> Imagine you pulled from somewhere else and it conflicted,
> requiring you to hand resolve and then run git-commit.

Hmm.. It seems that both sets of environment variables must be 
properly set before commit will succeed?  For some reason I thought 
that if AUTHOR was properly set it would be used as the committer too
when the GIT_COMMITTER_* environment variables weren't set.  All I
ever use are the config user.email/name variables which do work for
both author and committer.

But it looks like we have to test both variables before proceeding.

 git-commit.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


801ac3c2e4ec7fd0dd91975800897f30938b4e68
diff --git a/git-commit.sh b/git-commit.sh
index 26cd7ca..6ef1a9d 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -640,6 +640,8 @@ case "$no_edit" in
 		exit 1
 		;;
 	esac
+	git-var GIT_AUTHOR_IDENT > /dev/null  || die
+	git-var GIT_COMMITTER_IDENT > /dev/null  || die
 	${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"
 	;;
 esac
-- 
1.3.2.gd9a4

```