# stgit bug: pulling file deletion patch leaves copy of file 2 messages from 2006-05-08 to 2006-05-08. Participants: Karl Hasselström, Catalin Marinas. Thread: https://gitlist.dev/t/4101 ## Karl Hasselström, 2006-05-08 12:41 Subject: stgit bug: pulling file deletion patch leaves copy of file Message-ID: <20060508124127.GA30662@diana.vm.bytemark.co.uk> URL: https://gitlist.dev/e/20060508124127.GA30662%40diana.vm.bytemark.co.uk ``` When I pull (with -m) a branch that has accepted a patch of mine which deletes a file, stgit does the right thing wrt detecting the applied patch, etc. But it leaves an untracked copy of the deleted file in my working directory, which I get to delete. I suspect this file should be deleted -- but isn't -- by the patch merge detection code that undoes the application of the reverse of my patch. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle ``` ## Catalin Marinas, 2006-05-08 14:26 Subject: Re: stgit bug: pulling file deletion patch leaves copy of file Message-ID: URL: https://gitlist.dev/e/b0943d9e0605080726n75fd1e9avc48b7b932774d9ea%40mail.gmail.com In-Reply-To: <20060508124127.GA30662@diana.vm.bytemark.co.uk> ``` On 08/05/06, Karl Hasselström wrote: > When I pull (with -m) a branch that has accepted a patch of mine which > deletes a file, stgit does the right thing wrt detecting the applied > patch, etc. But it leaves an untracked copy of the deleted file in my > working directory, which I get to delete. Indeed, it should but it doesn't. The file is generated while reverse-applying the patches but the git.reset() function (which calls git.checkout()) doesn't remove the file. I'll fix it and push the changes tonight. Thanks. -- Catalin ```