# [PATCH] Fix quoting of redirect in test script 3 messages from 2015-12-02 to 2015-12-04. Participants: Charles Bailey, Junio C Hamano. Thread: https://gitlist.dev/t/40925 ## Charles Bailey, 2015-12-02 20:50 Subject: [PATCH] Fix quoting of redirect in test script Message-ID: <1449089407-14921-1-git-send-email-charles@hashpling.org> URL: https://gitlist.dev/e/1449089407-14921-1-git-send-email-charles%40hashpling.org ``` From: Charles Bailey --- t/t3404-rebase-interactive.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) If you are using bash (at least 4.3.30 or 4.3.42) this actually causes an error due to an "ambiguous redirect" because there is a space in "trash directory". diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh index 98eb49a..9067e02 100755 --- a/t/t3404-rebase-interactive.sh +++ b/t/t3404-rebase-interactive.sh @@ -1234,7 +1234,7 @@ test_expect_success 'tabs and spaces are accepted in the todolist' ' # Turn single spaces into space/tab mix sed "1s/ / /g; 2s/ / /g; 3s/ / /g" "$1" printf "\n\t# comment\n #more\n\t # comment\n" - ) >$1.new + ) >"$1.new" mv "$1.new" "$1" EOF test_set_editor "$(pwd)/add-indent.sh" && -- 2.4.0.53.g8440f74 ``` ## Junio C Hamano, 2015-12-04 21:05 Subject: Re: [PATCH] Fix quoting of redirect in test script Message-ID: URL: https://gitlist.dev/e/xmqqzixprkkv.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1449089407-14921-1-git-send-email-charles@hashpling.org> ``` Do you want to sign-off this patch? Thanks. ``` ## Charles Bailey, 2015-12-04 21:39 Subject: Re: [PATCH] Fix quoting of redirect in test script Message-ID: <20151204213944.GA14137@hashpling.org> URL: https://gitlist.dev/e/20151204213944.GA14137%40hashpling.org In-Reply-To: ``` On Fri, Dec 04, 2015 at 01:05:20PM -0800, Junio C Hamano wrote: > Do you want to sign-off this patch? > > Thanks. Oops, yes please. Signed-off-by: Charles Bailey ```