# [PATCH] test_must_fail: compare exit_code using integer -eq operator 2 messages from 2015-11-25 to 2015-11-28. Participants: Ramsay Jones, Jeff King. Thread: https://gitlist.dev/t/40893 ## Ramsay Jones, 2015-11-25 22:05 Subject: [PATCH] test_must_fail: compare exit_code using integer -eq operator Message-ID: <565630A4.7070205@ramsayjones.plus.com> URL: https://gitlist.dev/e/565630A4.7070205%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Jeff, Can we squash this into your fixup? ATB, Ramsay Jones t/test-lib-functions.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 85aeaf9..2bb639e 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -605,22 +605,22 @@ test_must_fail () { esac "$@" exit_code=$? - if test $exit_code = 0 && ! test_list_contains "$_test_ok" success + if test $exit_code -eq 0 && ! test_list_contains "$_test_ok" success then echo >&2 "test_must_fail: command succeeded: $*" return 1 - elif test $exit_code = 141 && test_list_contains "$_test_ok" sigpipe + elif test $exit_code -eq 141 && test_list_contains "$_test_ok" sigpipe then return 0 elif test $exit_code -gt 129 && test $exit_code -le 192 then echo >&2 "test_must_fail: died by signal: $*" return 1 - elif test $exit_code = 127 + elif test $exit_code -eq 127 then echo >&2 "test_must_fail: command not found: $*" return 1 - elif test $exit_code = 126 + elif test $exit_code -eq 126 then echo >&2 "test_must_fail: valgrind error: $*" return 1 -- 2.6.0 ``` ## Jeff King, 2015-11-28 16:58 Subject: Re: [PATCH] test_must_fail: compare exit_code using integer -eq operator Message-ID: <20151128165806.GA27264@sigill.intra.peff.net> URL: https://gitlist.dev/e/20151128165806.GA27264%40sigill.intra.peff.net In-Reply-To: <565630A4.7070205@ramsayjones.plus.com> ``` On Wed, Nov 25, 2015 at 10:05:24PM +0000, Ramsay Jones wrote: > Hi Jeff, > > Can we squash this into your fixup? I think it's a good thing to do, but I had figured it could be a separate patch (especially since it is touching lines that are otherwise unchanged by the patch). Looks like Lars folded it into his patch, though, and I am OK with that, too. -Peff ```