threads / patch / 40892

patchbuiltin/ff-refs.c: mark some file-local variables static

Subject: [PATCH] builtin/ff-refs.c: mark some file-local variables static

## tl;dr

One message between Nov 25, 2015 and Nov 25, 2015. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Nov 25, 2015, 22:01 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Michael,

If you need to re-roll the patches in your 'mr/ff-refs' branch, could you please squash parts of this patch into the relevant patches from your branch.

Thanks.

Also, I note that gcc complains about the two calls to chdir(). (warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result [-Wunused-result])

ATB, Ramsay Jones

 builtin/ff-refs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Show changes to builtin/ff-refs.c +4 −4
diff --git a/builtin/ff-refs.c b/builtin/ff-refs.c
index ae68cfb..db8c378 100644
--- a/builtin/ff-refs.c
+++ b/builtin/ff-refs.c
@@ -5,10 +5,10 @@
 #include "run-command.h"
 #include "worktree.h"
 
-int dry_run = 0;
-int no_wt = 0;
-struct worktree **worktrees;
-const char *padding = ".....................................................";
+static int dry_run = 0;
+static int no_wt = 0;
+static struct worktree **worktrees;
+static const char *padding = ".....................................................";
 
 static const char * const builtin_ff_refs_usage[] = {
 	N_("git ff-refs [<options>]"),
-- 
2.6.0

← back to recent threads