# [PATCH] blame: add test case for using tag object as a final ref 2 messages from 2015-11-18 to 2015-11-18. Participants: Max Kirillov, Jeff King. Thread: https://gitlist.dev/t/40823 ## Max Kirillov, 2015-11-18 05:36 Subject: [PATCH] blame: add test case for using tag object as a final ref Message-ID: <1447824992-28520-1-git-send-email-max@max630.net> URL: https://gitlist.dev/e/1447824992-28520-1-git-send-email-max%40max630.net ``` It was discovered [1] that 1b0d40000a broke blaming starting from tag object. Add test which verifies such blaming works. [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net Signed-off-by: Max Kirillov --- Thank you. Sorry, I should have noticed that obj ended up unused. Adding test case for it. Looks ok after the fix. t/annotate-tests.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh index b1673b3..093832f 100644 --- a/t/annotate-tests.sh +++ b/t/annotate-tests.sh @@ -68,6 +68,13 @@ test_expect_success 'blame 1 author' ' check_count A 2 ' +test_expect_success 'blame by tag objects' ' + git tag -m "test tag" testTag && + git tag -m "test tag #2" testTag2 testTag && + check_count -h testTag A 2 && + check_count -h testTag2 A 2 +' + test_expect_success 'setup B lines' ' echo "2A quick brown fox jumps over the" >>file && echo "lazy dog" >>file && -- 2.3.4.2801.g3d0809b ``` ## Jeff King, 2015-11-18 06:00 Subject: Re: [PATCH] blame: add test case for using tag object as a final ref Message-ID: <20151118060018.GA22541@sigill.intra.peff.net> URL: https://gitlist.dev/e/20151118060018.GA22541%40sigill.intra.peff.net In-Reply-To: <1447824992-28520-1-git-send-email-max@max630.net> ``` On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote: > It was discovered [1] that 1b0d40000a broke blaming starting from tag object. > Add test which verifies such blaming works. > > [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net > > Signed-off-by: Max Kirillov > --- > Thank you. Sorry, I should have noticed that obj ended up unused. Thanks. Do you mind if I just squash this into the patch with the fix? -Peff ```