# [PATCH/RFC (git-core)] squelch pack-object eye-candy on non-tty

2 messages from 2006-05-05 to 2006-05-05. Participants: Junio C Hamano, Johannes Schindelin.
Thread: https://gitlist.dev/t/4069

## Junio C Hamano, 2006-05-05 10:20

Subject: [PATCH/RFC (git-core)] squelch pack-object eye-candy on non-tty
Message-ID: <7vmzdwzsar.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vmzdwzsar.fsf%40assigned-by-dhcp.cox.net

```
One of my post-update scripts runs a git-fetch into a separate
repository and sends the results back to me (2>&1); I end up
getting this in the mail:

    Generating pack...
    Done counting 180 objects.
    Result has 131 objects.
    Deltifying 131 objects.
       0% (0/131) done^M   1% (2/131) done^M...

This defaults not to do the progress report when not on a tty.

You could give --progress to force the progress report, but
let's not bother even documenting it nor mentioning it in the
usage string.

---
diff --git a/pack-objects.c b/pack-objects.c
index 6604338..53caed4 100644
--- a/pack-objects.c
+++ b/pack-objects.c
@@ -1239,6 +1239,7 @@ int main(int argc, char **argv)
 
 	setup_git_directory();
 
+	progress = isatty(2);
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 
@@ -1269,6 +1270,10 @@ int main(int argc, char **argv)
 					usage(pack_usage);
 				continue;
 			}
+			if (!strcmp("--progress", arg)) {
+				progress = 1;
+				continue;
+			}
 			if (!strcmp("-q", arg)) {
 				progress = 0;
 				continue;

```

## Johannes Schindelin, 2006-05-05 11:19

Subject: Re: [PATCH/RFC (git-core)] squelch pack-object eye-candy on non-tty
Message-ID: <Pine.LNX.4.63.0605051319250.7784@wbgn013.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0605051319250.7784%40wbgn013.biozentrum.uni-wuerzburg.de
In-Reply-To: <7vmzdwzsar.fsf@assigned-by-dhcp.cox.net>

```
Hi,

On Fri, 5 May 2006, Junio C Hamano wrote:

> This defaults not to do the progress report when not on a tty.

Melikes,
Dscho

```