# git-gui is still using old-style git-merge invocation

3 messages from 2015-10-29 to 2015-10-29. Participants: Johannes Sixt, Dennis Kaarsemaker.
Thread: https://gitlist.dev/t/40671

## Johannes Sixt, 2015-10-29 17:50

Subject: git-gui is still using old-style git-merge invocation
Message-ID: <56325C58.1060007@kdbg.org>
URL: https://gitlist.dev/e/56325C58.1060007%40kdbg.org

```
Performing a merge with git gui presents the following message in the 
merge result window:

warning: old-style 'git merge <msg> HEAD <commit>' is deprecated.
Merge made by the 'recursive' strategy.
  a | 1 +
  1 file changed, 1 insertion(+)
  create mode 100644 a

But I am unable to find where the invocation happens. Can somebody help?

-- Hannes

PS: Reproducer:

git init
echo a > a
git add a
git commit -ma a
git checkout -b side @~
echo b > b
git add b
git commit -mb
git gui      # to merge: Ctrl-M, Enter, Enter

```

## Dennis Kaarsemaker, 2015-10-29 17:56

Subject: Re: git-gui is still using old-style git-merge invocation
Message-ID: <1446141395.3199.2.camel@kaarsemaker.net>
URL: https://gitlist.dev/e/1446141395.3199.2.camel%40kaarsemaker.net
In-Reply-To: <56325C58.1060007@kdbg.org>

```
On do, 2015-10-29 at 18:50 +0100, Johannes Sixt wrote:
> Performing a merge with git gui presents the following message in the
> merge result window:
> 
> warning: old-style 'git merge <msg> HEAD <commit>' is deprecated.
> Merge made by the 'recursive' strategy.
>   a | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 a
> 
> But I am unable to find where the invocation happens. Can somebody
> help?

git-gui/lib/merge.tcl, method _start

The command is constructed on lines 115-120 (master as of today,
 37023ba3)
-- 
Dennis Kaarsemaker
www.kaarsemaker.net

```

## Johannes Sixt, 2015-10-29 19:31

Subject: Re: git-gui is still using old-style git-merge invocation
Message-ID: <56327407.2050607@kdbg.org>
URL: https://gitlist.dev/e/56327407.2050607%40kdbg.org
In-Reply-To: <1446141395.3199.2.camel@kaarsemaker.net>

```
Thanks!

```