threads / patch / 40572

patchfetch: only show "Fetching remote" when verbose mode is enabled

Subject: [PATCH] fetch: only show "Fetching remote" when verbose mode is enabled

## tl;dr

One message between Oct 16, 2015 and Oct 16, 2015. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Paul Wise· Oct 16, 2015, 06:49 UTC · lore

By default when fetching one remote nothing is printed unless there are changes that need fetching. This makes fetching multiple remotes be just as verbose as fetching a single remote.

This is needed when fetching multiple repositories using the myrepos tool in minimal output mode, where myrepos only prints the repository names when git fetch prints some output. For example in the output below the cgit and git-remote-* lines would be hidden if git fetch were silent by default when fetching multiple remotes, since the default for myrepos is to fetch all remotes for git repositories.

pabs@chianamo ~ $ mr -m fetch mr fetch: /home/pabs/cgit Fetching origin

mr fetch: /home/pabs/git
Fetching origin
From https://github.com/git/git
 - [tag update]      junio-gpg-pub -> junio-gpg-pub
Fetching hg
From https://github.com/SRabbelier/git
 - [tag update]      junio-gpg-pub -> junio-gpg-pub

mr fetch: /home/pabs/git-remote-bzr Fetching origin

mr fetch: /home/pabs/git-remote-hg Fetching origin

Signed-off-by: Paul Wise <pabs3@bonedaddy.net>
---
 builtin/fetch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/fetch.c +1 −1
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 9a3869f..fc33667 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1067,7 +1067,7 @@ static int fetch_multiple(struct string_list *list)
 	for (i = 0; i < list->nr; i++) {
 		const char *name = list->items[i].string;
 		argv_array_push(&argv, name);
-		if (verbosity >= 0)
+		if (verbosity >= 1)
 			printf(_("Fetching %s\n"), name);
 		if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) {
 			error(_("Could not fetch %s"), name);
-- 
2.6.1

← back to recent threads