threads / patch / 40460

patchgitk: add missing accelerators

Subject: [PATCH] gitk: add missing accelerators

## tl;dr

2 messages between Sep 30, 2015 and Oct 30, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Beat Bolli· Sep 30, 2015, 19:50 UTC · lore

In d99b4b0de27a ("gitk: Accelerators for the main menu", 2015-09-09), accelerators were added to allow efficient keyboard navigation. One instance of the strings "Edit view..." and "Delete view" were left without the ampersand.

Add the missing ampersand characters to unbreak our international users.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Cc: Paul Mackerras <paulus@samba.org>
---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to gitk-git/gitk +2 −2
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 2028b55..fcc606e 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -12452,8 +12452,8 @@ if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {
     set viewchanged(1) 0
     set vdatemode(1) 0
     addviewmenu 1
-    .bar.view entryconf [mca "Edit view..."] -state normal
-    .bar.view entryconf [mca "Delete view"] -state normal
+    .bar.view entryconf [mca "&Edit view..."] -state normal
+    .bar.view entryconf [mca "&Delete view"] -state normal
 }
 
 if {[info exists permviews]} {
-- 
2.6.0
Paul Mackerras· Oct 30, 2015, 09:56 UTC · re: Beat Bolli · lore

Re: [PATCH] gitk: add missing accelerators

On Wed, Sep 30, 2015 at 09:50:11PM +0200, Beat Bolli wrote:
Show 10 quoted lines
> In d99b4b0de27a ("gitk: Accelerators for the main menu", 2015-09-09),
> accelerators were added to allow efficient keyboard navigation. One
> instance of the strings "Edit view..." and "Delete view" were left
> without the ampersand.
> 
> Add the missing ampersand characters to unbreak our international
> users.
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> Cc: Paul Mackerras <paulus@samba.org>
Thanks, applied.
Paul.

← back to recent threads