threads / patch / 40452

patchgit-send-email.perl: Fixed sending of many changes/patches

Subject: [PATCH] git-send-email.perl: Fixed sending of many changes/patches

## tl;dr

2 messages between Sep 29, 2015 and Sep 29, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Lars Wendler· Sep 29, 2015, 15:00 UTC · lore
From: Stefan Agner <stefan@agner.ch>
See http://permalink.gmane.org/gmane.comp.version-control.git/274569
Reported-by: Juston Li <juston.h.li@gmail.com>
Tested-by: Markos Chandras <hwoarang@gentoo.org>
Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
---
 git-send-email.perl | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Show changes to git-send-email.perl +5 −1
diff --git a/git-send-email.perl b/git-send-email.perl
index e3ff44b..e907e0ea 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1365,7 +1365,11 @@ Message-Id: $message_id
 		$smtp->mail( $raw_from ) or die $smtp->message;
 		$smtp->to( @recipients ) or die $smtp->message;
 		$smtp->data or die $smtp->message;
-		$smtp->datasend("$header\n$message") or die $smtp->message;
+		$smtp->datasend("$header\n") or die $smtp->message;
+		my @lines = split /^/, $message;
+		foreach my $line (@lines) {
+			$smtp->datasend("$line") or die $smtp->message;
+		}
 		$smtp->dataend() or die $smtp->message;
 		$smtp->code =~ /250|200/ or die "Failed to send $subject\n".$smtp->message;
 	}
-- 
2.6.0
Johannes Schindelin· Sep 29, 2015, 15:43 UTC · re: Lars Wendler · lore

Re: [PATCH] git-send-email.perl: Fixed sending of many changes/patches

Hi Lars,
On 2015-09-29 17:00, Lars Wendler wrote:
> From: Stefan Agner <stefan@agner.ch>
> 
> See http://permalink.gmane.org/gmane.comp.version-control.git/274569
Please summarize the linked discussion in the commit message, as it is the convention here in the Git project to make commit messages self-sufficient, with links thrown in only to provide more context when desired.

Ciao, Johannes

← back to recent threads