# [PATCH v2] git-p4: improve path encoding verbose output 2 messages from 2015-09-16 to 2015-09-16. Participants: larsxschneider@gmail.com. Thread: https://gitlist.dev/t/40363 ## larsxschneider@gmail.com, 2015-09-16 12:37 Subject: [PATCH v2] git-p4: improve path encoding verbose output Message-ID: <1442407024-33516-1-git-send-email-larsxschneider@gmail.com> URL: https://gitlist.dev/e/1442407024-33516-1-git-send-email-larsxschneider%40gmail.com ``` From: Lars Schneider Follow up patch for a9e38359 (git-p4: add config git-p4.pathEncoding, 2015-09-03) which is already on 'next'. diff to v1 (wrongly called v7 in "[PATCH v7] git-p4: add config git-p4.pathEncoding") * make path encoding for utf-8 default case more explicit (thanks Junio!) * improve commit message (thanks Luke!) Cheers, Lars Lars Schneider (1): git-p4: improve path encoding verbose output git-p4.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) -- 2.5.1 ``` ## larsxschneider@gmail.com, 2015-09-16 12:37 Subject: [PATCH v2] git-p4: improve path encoding verbose output Message-ID: <1442407024-33516-2-git-send-email-larsxschneider@gmail.com> URL: https://gitlist.dev/e/1442407024-33516-2-git-send-email-larsxschneider%40gmail.com In-Reply-To: <1442407024-33516-1-git-send-email-larsxschneider@gmail.com> ``` From: Lars Schneider If a path with non-ASCII characters is detected then print the encoding and the encoded string in verbose mode. Signed-off-by: Lars Schneider --- git-p4.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/git-p4.py b/git-p4.py index d45cf2b..e7510a9 100755 --- a/git-p4.py +++ b/git-p4.py @@ -2220,16 +2220,15 @@ class P4Sync(Command, P4UserMap): text = regexp.sub(r'$\1$', text) contents = [ text ] - if gitConfig("git-p4.pathEncoding"): - relPath = relPath.decode(gitConfig("git-p4.pathEncoding")).encode('utf8', 'replace') - elif self.verbose: - try: - relPath.decode('ascii') - except: - print ( - "Path with Non-ASCII characters detected and no path encoding defined. " - "Please check the encoding: %s" % relPath - ) + try: + relPath.decode('ascii') + except: + encoding = 'utf8' + if gitConfig('git-p4.pathEncoding'): + encoding = gitConfig('git-p4.pathEncoding') + relPath = relPath.decode(encoding).encode('utf8', 'replace') + if self.verbose: + print 'Path with non-ASCII characters detected. Used %s to encode: %s ' % (encoding, relPath) self.gitStream.write("M %s inline %s\n" % (git_mode, relPath)) -- 2.5.1 ```