threads / patch / 40240

patchpath.c: make 'common_list' a file local symbol

Subject: [PATCH] path.c: make 'common_list' a file local symbol

## tl;dr

2 messages between Sep 1, 2015 and Sep 1, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Sep 1, 2015, 15:54 UTC · lore

Commit 04afda89 ("refs: clean up common_list", 26-08-2015) changed the type of the 'common_list' symbol from an array of 'formatted' strings to an array of struct containing the same data. However, in addition it also (inadvertently) changed the visibility of the symbol from file local to external.

In order to revert the visibility of the symbol to file local, add the static modifier to the declaration of 'common_list'.

Noticed by sparse (symbol 'common_list' was not declared. Should it be static?).

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi David,

If you need to re-roll the patches on your 'dt/refs-bisection' branch, could you please squash this into the relevant patch.

Thanks!

ATB, Ramsay Jones

 path.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to path.c +1 −1

diff --git a/path.c b/path.c
index 9d32d19..a80eaf7 100644
--- a/path.c
+++ b/path.c
@@ -100,7 +100,7 @@ struct common_dir {
     const char *dirname;
 };
 
-struct common_dir common_list[] = {
+static struct common_dir common_list[] = {
     { 0, 1, 0, "branches" },
     { 0, 1, 0, "hooks" },
     { 0, 1, 0, "info" },

-- 
2.5.0

Junio C Hamano· Sep 1, 2015, 18:06 UTC · re: Ramsay Jones · lore

Re: [PATCH] path.c: make 'common_list' a file local symbol

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 21 quoted lines

> Commit 04afda89 ("refs: clean up common_list", 26-08-2015) changed
> the type of the 'common_list' symbol from an array of 'formatted'
> strings to an array of struct containing the same data. However, in
> addition it also (inadvertently) changed the visibility of the
> symbol from file local to external.
>
> In order to revert the visibility of the symbol to file local, add
> the static modifier to the declaration of 'common_list'.
>
> Noticed by sparse (symbol 'common_list' was not declared. Should it
> be static?).
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi David,
>
> If you need to re-roll the patches on your 'dt/refs-bisection' branch, could you
> please squash this into the relevant patch.
>
> Thanks!

Thanks.  I've squashed this into David's [v5 1/3] while queuing.

Show 20 quoted lines

>
> ATB,
> Ramsay Jones
>
>  path.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/path.c b/path.c
> index 9d32d19..a80eaf7 100644
> --- a/path.c
> +++ b/path.c
> @@ -100,7 +100,7 @@ struct common_dir {
>      const char *dirname;
>  };
>  
> -struct common_dir common_list[] = {
> +static struct common_dir common_list[] = {
>      { 0, 1, 0, "branches" },
>      { 0, 1, 0, "hooks" },
>      { 0, 1, 0, "info" },