# [PATCH] read-cache: fix indentation in read_index_from 4 messages from 2015-08-31 to 2015-08-31. Participants: Stefan Beller, Junio C Hamano. Thread: https://gitlist.dev/t/40231 ## Stefan Beller, 2015-08-31 18:43 Subject: [PATCH] read-cache: fix indentation in read_index_from Message-ID: <1441046609-24181-1-git-send-email-sbeller@google.com> URL: https://gitlist.dev/e/1441046609-24181-1-git-send-email-sbeller%40google.com ``` Signed-off-by: Stefan Beller --- read-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index 89dbc08..a3df665 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1653,7 +1653,7 @@ int read_index_from(struct index_state *istate, const char *path) die("broken index, expect %s in %s, got %s", sha1_to_hex(split_index->base_sha1), git_path("sharedindex.%s", - sha1_to_hex(split_index->base_sha1)), + sha1_to_hex(split_index->base_sha1)), sha1_to_hex(split_index->base->sha1)); merge_base_index(istate); check_ce_order(istate); -- 2.5.0.264.geed6e44.dirty ``` ## Junio C Hamano, 2015-08-31 19:29 Subject: Re: [PATCH] read-cache: fix indentation in read_index_from Message-ID: URL: https://gitlist.dev/e/xmqqpp23uuhk.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1441046609-24181-1-git-send-email-sbeller@google.com> ``` Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > read-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/read-cache.c b/read-cache.c > index 89dbc08..a3df665 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -1653,7 +1653,7 @@ int read_index_from(struct index_state *istate, const char *path) > die("broken index, expect %s in %s, got %s", > sha1_to_hex(split_index->base_sha1), > git_path("sharedindex.%s", > - sha1_to_hex(split_index->base_sha1)), > + sha1_to_hex(split_index->base_sha1)), We allow two styles in our codebase, (1) indent to align with opening parenthesis, or (2) indent sufficiently deeper than the first line with HT. The original is neither, so in that sense it is a good thing to do in the long run. I'll queue it for this time, but in general, I'd prefer if people refrained from touching code only for style fixes in an area that is touched actively in topics, unless it is done inside a topic that has to touch that area of the code in order to do something more than style fixes. Thanks. > sha1_to_hex(split_index->base->sha1)); > merge_base_index(istate); > check_ce_order(istate); ``` ## Stefan Beller, 2015-08-31 19:34 Subject: Re: [PATCH] read-cache: fix indentation in read_index_from Message-ID: URL: https://gitlist.dev/e/CAGZ79kbQmmcJMW%3D07A1pyHdbViJTfseG4L-kspKEvyugTO7R4g%40mail.gmail.com In-Reply-To: ``` On Mon, Aug 31, 2015 at 12:29 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> --- >> read-cache.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/read-cache.c b/read-cache.c >> index 89dbc08..a3df665 100644 >> --- a/read-cache.c >> +++ b/read-cache.c >> @@ -1653,7 +1653,7 @@ int read_index_from(struct index_state *istate, const char *path) >> die("broken index, expect %s in %s, got %s", >> sha1_to_hex(split_index->base_sha1), >> git_path("sharedindex.%s", >> - sha1_to_hex(split_index->base_sha1)), >> + sha1_to_hex(split_index->base_sha1)), > > We allow two styles in our codebase, (1) indent to align with > opening parenthesis, or (2) indent sufficiently deeper than the > first line with HT. The original is neither, so in that sense > it is a good thing to do in the long run. > > I'll queue it for this time, but in general, I'd prefer if people > refrained from touching code only for style fixes in an area that is > touched actively in topics, unless it is done inside a topic that > has to touch that area of the code in order to do something more > than style fixes. Right. :( The problem here is that I was looking to use read_index_from in the submodule code to implement recursive actions, but as I could not find documentation on how to use it, I read the code. And whenever I see obvious things to fix (such as style), I cannot stop myself from shooting from the hip, sending a patch. I'll stop doing that. > > Thanks. > >> sha1_to_hex(split_index->base->sha1)); >> merge_base_index(istate); >> check_ce_order(istate); ``` ## Junio C Hamano, 2015-08-31 20:12 Subject: Re: [PATCH] read-cache: fix indentation in read_index_from Message-ID: URL: https://gitlist.dev/e/xmqq613vusj0.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Stefan Beller writes: >> I'll queue it for this time, but in general, I'd prefer if people >> refrained from touching code only for style fixes in an area that is >> touched actively in topics, unless it is done inside a topic that >> has to touch that area of the code in order to do something more >> than style fixes. > > Right. :( > > The problem here is that I was looking to use read_index_from > in the submodule code to implement recursive actions, but as I > could not find documentation on how to use it, I read the code. > And whenever I see obvious things to fix (such as style), > I cannot stop myself from shooting from the hip, sending a patch. > I'll stop doing that. Don't stop; instead queue and keep them on your own queue, so that you can find a good time to send them out. A good rule-of-thumb for "good time" is when "git diff maint pu" does not show any overlap to the context and preimage of your patches. Thanks. ```