[PATCH] git-fsck-cache: Gracefully handle non-commit IDs

Jonas Fonseca· Apr 30, 2005, 00:28 UTC · lore

Gracefully handle non-commit IDs instead of segfaulting.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>

--- 09465be469eef9711e93b583f4cd1092baa58f90/fsck-cache.c (mode:100644 sha1:280a104050b665515418c00c33af8e6b0b0e2101) +++ uncommitted/fsck-cache.c (mode:100644)

Show changes to diff +8 −1

@@ -174,7 +216,14 @@
 			continue;
 
 		if (!get_sha1_hex(arg, head_sha1)) {
-			struct object *obj = &lookup_commit(head_sha1)->object;
+			struct commit *commit = lookup_commit(head_sha1);
+			struct object *obj;
+
+			/* Error is printed by lookup_commit(). */
+			if (!commit)
+				continue;
+
+			obj = &commit->object;
 			obj->used = 1;
 			mark_reachable(obj, REACHABLE);
 			heads++;

-- 
Jonas Fonseca

patchgit-fsck-cache: Gracefully handle non-commit IDs