# [PATCH] git-submodule: remove extraneous space from error message 2 messages from 2015-08-27 to 2015-08-27. Participants: Alex Henrie, Chris Packham. Thread: https://gitlist.dev/t/40189 ## Alex Henrie, 2015-08-27 04:26 Subject: [PATCH] git-submodule: remove extraneous space from error message Message-ID: <1440649579-3513-1-git-send-email-alexhenrie24@gmail.com> URL: https://gitlist.dev/e/1440649579-3513-1-git-send-email-alexhenrie24%40gmail.com ``` Signed-off-by: Alex Henrie --- git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-submodule.sh b/git-submodule.sh index 36797c3..25b1ddf 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -904,7 +904,7 @@ Maybe you want to use 'update --init'?")" ;; !*) command="${update_module#!}" - die_msg="$(eval_gettext "Execution of '\$command \$sha1' failed in submodule path '\$prefix\$sm_path'")" + die_msg="$(eval_gettext "Execution of '\$command \$sha1' failed in submodule path '\$prefix\$sm_path'")" say_msg="$(eval_gettext "Submodule path '\$prefix\$sm_path': '\$command \$sha1'")" must_die_on_failure=yes ;; -- 2.5.0 ``` ## Chris Packham, 2015-08-27 09:17 Subject: Re: [PATCH] git-submodule: remove extraneous space from error message Message-ID: URL: https://gitlist.dev/e/CAFOYHZBG6uBoYE%3DJUHhBFO%3DbMNmX5GJowCr4Mg6x68GAdWykQw%40mail.gmail.com In-Reply-To: <1440649579-3513-1-git-send-email-alexhenrie24@gmail.com> ``` On Thu, Aug 27, 2015 at 4:26 PM, Alex Henrie wrote: > Signed-off-by: Alex Henrie > --- > git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-submodule.sh b/git-submodule.sh > index 36797c3..25b1ddf 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -904,7 +904,7 @@ Maybe you want to use 'update --init'?")" > ;; > !*) > command="${update_module#!}" > - die_msg="$(eval_gettext "Execution of '\$command \$sha1' failed in submodule path '\$prefix\$sm_path'")" > + die_msg="$(eval_gettext "Execution of '\$command \$sha1' failed in submodule path '\$prefix\$sm_path'")" > say_msg="$(eval_gettext "Submodule path '\$prefix\$sm_path': '\$command \$sha1'")" > must_die_on_failure=yes > ;; > -- > 2.5.0 > Looks good to me. Thanks Reviewed-by: Chris Packham ```