# [PATCH v11 08/13] ref-filter: add support to sort by version 3 messages from 2015-08-15 to 2015-08-17. Participants: Karthik Nayak, Eric Sunshine. Thread: https://gitlist.dev/t/40099 ## Karthik Nayak, 2015-08-15 18:00 Subject: [PATCH v11 08/13] ref-filter: add support to sort by version Message-ID: <1439661643-16094-9-git-send-email-Karthik.188@gmail.com> URL: https://gitlist.dev/e/1439661643-16094-9-git-send-email-Karthik.188%40gmail.com ``` From: Karthik Nayak Add support to sort by version using the "v:refname" and "version:refname" option. This is achieved by using the 'versioncmp()' function as the comparing function for qsort. This option is included to support sorting by versions in `git tag -l` which will eventaully be ported to use ref-filter APIs. Add documentation and tests for the same. Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- Documentation/git-for-each-ref.txt | 3 +++ ref-filter.c | 15 ++++++++++----- ref-filter.h | 3 ++- t/t6302-for-each-ref-filter.sh | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 51 insertions(+), 6 deletions(-) diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt index 2b82334..3099631 100644 --- a/Documentation/git-for-each-ref.txt +++ b/Documentation/git-for-each-ref.txt @@ -153,6 +153,9 @@ For sorting purposes, fields with numeric values sort in numeric order (`objectsize`, `authordate`, `committerdate`, `taggerdate`). All other fields are used to sort in their byte-value order. +There is also an option to sort by versions, this can be done by using +the fieldname `version:refname` or its alias `v:refname`. + In any case, a field name that refers to a field inapplicable to the object referred by the ref does not cause an error. It returns an empty string instead. diff --git a/ref-filter.c b/ref-filter.c index 2f302b4..9ed83a3 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -11,6 +11,8 @@ #include "ref-filter.h" #include "revision.h" #include "utf8.h" +#include "git-compat-util.h" +#include "version.h" typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type; @@ -1302,19 +1304,19 @@ static int cmp_ref_sorting(struct ref_sorting *s, struct ref_array_item *a, stru get_ref_atom_value(a, s->atom, &va); get_ref_atom_value(b, s->atom, &vb); - switch (cmp_type) { - case FIELD_STR: + if (s->version) + cmp = versioncmp(va->s, vb->s); + else if (cmp_type == FIELD_STR) cmp = strcmp(va->s, vb->s); - break; - default: + else { if (va->ul < vb->ul) cmp = -1; else if (va->ul == vb->ul) cmp = 0; else cmp = 1; - break; } + return (s->reverse) ? -cmp : cmp; } @@ -1516,6 +1518,9 @@ int parse_opt_ref_sorting(const struct option *opt, const char *arg, int unset) s->reverse = 1; arg++; } + if (skip_prefix(arg, "version:", &arg) || + skip_prefix(arg, "v:", &arg)) + s->version = 1; len = strlen(arg); s->atom = parse_ref_filter_atom(arg, arg+len); return 0; diff --git a/ref-filter.h b/ref-filter.h index 0f2048d..a5b6d0e 100644 --- a/ref-filter.h +++ b/ref-filter.h @@ -28,7 +28,8 @@ struct atom_value; struct ref_sorting { struct ref_sorting *next; int atom; /* index into used_atom array (internal) */ - unsigned reverse : 1; + unsigned reverse : 1, + version : 1; }; struct ref_array_item { diff --git a/t/t6302-for-each-ref-filter.sh b/t/t6302-for-each-ref-filter.sh index b252a50..1c56879 100755 --- a/t/t6302-for-each-ref-filter.sh +++ b/t/t6302-for-each-ref-filter.sh @@ -129,4 +129,40 @@ test_expect_success 'right alignment' ' test_cmp expect actual ' +test_expect_success 'setup for version sort' ' + test_commit foo1.3 && + test_commit foo1.6 && + test_commit foo1.10 +' + +test_expect_success 'version sort' ' + git for-each-ref --sort=version:refname --format="%(refname:short)" refs/tags/ | grep "foo" >actual && + cat >expect <<-\EOF && + foo1.3 + foo1.6 + foo1.10 + EOF + test_cmp expect actual +' + +test_expect_success 'version sort (shortened)' ' + git for-each-ref --sort=v:refname --format="%(refname:short)" refs/tags/ | grep "foo" >actual && + cat >expect <<-\EOF && + foo1.3 + foo1.6 + foo1.10 + EOF + test_cmp expect actual +' + +test_expect_success 'reverse version sort' ' + git for-each-ref --sort=-version:refname --format="%(refname:short)" refs/tags/ | grep "foo" >actual && + cat >expect <<-\EOF && + foo1.10 + foo1.6 + foo1.3 + EOF + test_cmp expect actual +' + test_done -- 2.5.0 ``` ## Eric Sunshine, 2015-08-17 04:53 Subject: Re: [PATCH v11 08/13] ref-filter: add support to sort by version Message-ID: URL: https://gitlist.dev/e/CAPig%2BcRs3EbO1HmHmfNTaXXiiDjyqgeiUqv2_XGJL1%3DOgb6a2g%40mail.gmail.com In-Reply-To: <1439661643-16094-9-git-send-email-Karthik.188@gmail.com> ``` On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak wrote: > Add support to sort by version using the "v:refname" and > "version:refname" option. This is achieved by using the 'versioncmp()' > function as the comparing function for qsort. > > This option is included to support sorting by versions in `git tag -l` > which will eventaully be ported to use ref-filter APIs. s/eventaully/eventually/ > Add documentation and tests for the same. > > Signed-off-by: Karthik Nayak ``` ## Karthik Nayak, 2015-08-17 15:05 Subject: Re: [PATCH v11 08/13] ref-filter: add support to sort by version Message-ID: URL: https://gitlist.dev/e/CAOLa%3DZR%3Dxxbgeaqke6iA37cij8HMygOSzeHOD2jPYbXhmV2noQ%40mail.gmail.com In-Reply-To: ``` On Mon, Aug 17, 2015 at 10:23 AM, Eric Sunshine wrote: > On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak wrote: >> Add support to sort by version using the "v:refname" and >> "version:refname" option. This is achieved by using the 'versioncmp()' >> function as the comparing function for qsort. >> >> This option is included to support sorting by versions in `git tag -l` >> which will eventaully be ported to use ref-filter APIs. > > s/eventaully/eventually/ > Will change thanks :) >> Add documentation and tests for the same. >> >> Signed-off-by: Karthik Nayak -- Regards, Karthik Nayak ```