builtin/tag.c issue with sort option

Jacob Keller· Jul 28, 2015, 22:27 UTC · lore

When passing "-n" on the command line, if you have configured sort manually, you get an error as it thinks you passed --sort and -n.

It should automatically disable tag_sort if it wasn't passed from the command line, as you probably know what you are doing when passing -n

I'm attempting to work up a patch for this fix, but I am having a little bit of trouble and want to make sure it's right to fix this behavior.

Regards, Jake

Jacob Keller· Jul 28, 2015, 22:46 UTC · re: Jacob Keller · lore

Re: builtin/tag.c issue with sort option

On Tue, Jul 28, 2015 at 3:27 PM, Jacob Keller <jacob.keller@gmail.com> wrote:

Show 12 quoted lines

> When passing "-n" on the command line, if you have configured sort
> manually, you get an error as it thinks you passed --sort and -n.
>
> It should automatically disable tag_sort if it wasn't passed from the
> command line, as you probably know what you are doing when passing -n
>
> I'm attempting to work up a patch for this fix, but I am having a
> little bit of trouble and want to make sure it's right to fix this
> behavior.
>
> Regards,
> Jake

Actually, the sort and -n imcompatability is going away with the unification of tag using the ref-filter API, so I think this is actually not worth it to bother trying to fix, since it will be removed soon anyways.

Regards, Jake