# [PATCH v2] fetch-pack: check for shallow if depth given 1 messages from 2015-06-18 to 2015-06-18. Participants: Mike Edgar. Thread: https://gitlist.dev/t/39665 ## Mike Edgar, 2015-06-18 00:31 Subject: [PATCH v2] fetch-pack: check for shallow if depth given Message-ID: <1434587464-18337-1-git-send-email-adgar@google.com> URL: https://gitlist.dev/e/1434587464-18337-1-git-send-email-adgar%40google.com ``` When a repository is first fetched as a shallow clone, either by git-clone or by fetching into an empty repo, the server's capabilities are not currently consulted. The client will send shallow requests even if the server does not understand them, and the resulting error may be unhelpful to the user. This change pre-emptively checks so we can exit with a helpful error if necessary. Signed-off-by: Mike Edgar Acked-by: Jeff King --- fetch-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fetch-pack.c b/fetch-pack.c index 48526aa..849a9d6 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -790,7 +790,7 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args, sort_ref_list(&ref, ref_compare_name); qsort(sought, nr_sought, sizeof(*sought), cmp_ref_by_name); - if (is_repository_shallow() && !server_supports("shallow")) + if ((args->depth > 0 || is_repository_shallow()) && !server_supports("shallow")) die("Server does not support shallow clients"); if (server_supports("multi_ack_detailed")) { if (args->verbose) -- 2.4.3.573.g4eafbef ```