[PATCH] t0302: "unreadable" test needs SANITY prereq

Paul Tan· Jun 12, 2015, 13:29 UTC · lore

The test expects that "chmod -r ~/.git-credentials" would make it unreadable to the user, and thus needs the SANITY prerequisite.

Reported-by: Jean-Yves LENHOF <jean-yves@lenhof.eu.org>
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 t/t0302-credential-store.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t0302-credential-store.sh +1 −1

diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
index 0979df9..1d8d1f2 100755
--- a/t/t0302-credential-store.sh
+++ b/t/t0302-credential-store.sh
@@ -75,7 +75,7 @@ test_expect_success 'get: use xdg file if home file has no matches' '
 	EOF
 '
 
-test_expect_success POSIXPERM 'get: use xdg file if home file is unreadable' '
+test_expect_success POSIXPERM,SANITY 'get: use xdg file if home file is unreadable' '
 	echo "https://home-user:home-pass@example.com" >"$HOME/.git-credentials" &&
 	chmod -r "$HOME/.git-credentials" &&
 	mkdir -p "$HOME/.config/git" &&

-- 
2.1.4

Jeff King· Jun 12, 2015, 13:36 UTC · re: Paul Tan · lore

Re: [PATCH] t0302: "unreadable" test needs SANITY prereq

On Fri, Jun 12, 2015 at 09:29:58PM +0800, Paul Tan wrote:

> The test expects that "chmod -r ~/.git-credentials" would make it
> unreadable to the user, and thus needs the SANITY prerequisite.

Yup, looks obviously correct to me. Thanks for a quick turnaround.

-Peff

patcht0302: "unreadable" test needs SANITY prereq