# [PATCH 1/1]: git-completion.tcsh fails w/ noclobber 2 messages from 2015-06-08 to 2015-06-09. Participants: Ariel Faigon, Christian Couder. Thread: https://gitlist.dev/t/39568 ## Ariel Faigon, 2015-06-08 23:01 Subject: [PATCH 1/1]: git-completion.tcsh fails w/ noclobber Message-ID: <20150608230133.GA14473@yendor.com> URL: https://gitlist.dev/e/20150608230133.GA14473%40yendor.com ``` tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated. Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users. Helped-by: Junio C Hamano Mentored-by: Christian Couder Signed-off-by: Ariel Faigon --- contrib/completion/git-completion.tcsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh index 6104a42..4a790d8 100644 --- a/contrib/completion/git-completion.tcsh +++ b/contrib/completion/git-completion.tcsh @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then exit endif -cat << EOF > ${__git_tcsh_completion_script} +cat << EOF >! ${__git_tcsh_completion_script} #!bash # # This script is GENERATED and will be overwritten automatically. ``` ## Christian Couder, 2015-06-09 09:25 Subject: Re: [PATCH 1/1]: git-completion.tcsh fails w/ noclobber Message-ID: URL: https://gitlist.dev/e/CAP8UFD0s4ea5CPYUV1FWbi_eeK%3DV9a%2Ba6MW75o9RwtyQ7RzhNg%40mail.gmail.com In-Reply-To: <20150608230133.GA14473@yendor.com> ``` The subject is better but still not quite there. I suggest: [PATCH] git-completion.tcsh: fix redirect with noclobber On Tue, Jun 9, 2015 at 1:01 AM, Ariel Faigon wrote: > tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated. Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users. > > Helped-by: Junio C Hamano The email address look wrong. If he really helped you, he probably emailed you using another address. > Mentored-by: Christian Couder "Mentored-by:" is used by Google Summer of Code students. If someone helps you and you want to acknowledge that, you can add an "Helped-by:" trailer (unless your helper tells you that you can add a "Reviewed-by:" or maybe a "Signed-off-by:"). > Signed-off-by: Ariel Faigon > --- ```