# Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit 2 messages from 2015-05-29 to 2015-05-29. Participants: Remi Galan Alfonso, Junio C Hamano. Thread: https://gitlist.dev/t/39456 ## Remi Galan Alfonso, 2015-05-29 08:33 Subject: Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit Message-ID: <1416141686.132444.1432888411621.JavaMail.zimbra@ensimag.grenoble-inp.fr> URL: https://gitlist.dev/e/1416141686.132444.1432888411621.JavaMail.zimbra%40ensimag.grenoble-inp.fr In-Reply-To: <1836557143.132299.1432888016868.JavaMail.zimbra@ensimag.grenoble-inp.fr> ``` At first we wanted a clear indication about removing a commit in rebase -i. We didn't know about the noop command. - 'noop' does the same thing as 'drop' but for the user deleting a commit through 'noop' doesn't seem to be the proper way to use this command. Moreover 'noop' is not documented (especially it is not shown in the short help that is display in the editor during the rebase -i) - Commenting the line does the same but will cause problems with the second part of the patch (warn about removed commits) because the line is then not taken into consideration. We wanted to add the 'drop' command because we wanted a way for clearly deleting a commit (and also for the second part of the patch) and there is no clear way so far. ``` ## Junio C Hamano, 2015-05-29 15:36 Subject: Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit Message-ID: URL: https://gitlist.dev/e/xmqqwpzre6q9.fsf%40gitster.dls.corp.google.com In-Reply-To: <1416141686.132444.1432888411621.JavaMail.zimbra@ensimag.grenoble-inp.fr> ``` Remi Galan Alfonso writes: > At first we wanted a clear indication about removing a commit in > rebase -i. We didn't know about the noop command. > - 'noop' does the same thing as 'drop' but for the user deleting a > commit through 'noop' doesn't seem to be the proper way to use this > command. Moreover 'noop' is not documented (especially it is not > shown in the short help that is display in the editor during the > rebase -i) As Matthieu said elsewhere during the discussion, 'noop' is merely to ignore everything that follows (so 'noop stupid git' does not mean "ignore commit identified by 'stupid git'") and the only reason why it exists is as a hack to have a way to make a non-empty todo list, because an empty todo list means "do not do anything, not even rewinding to the onto commit". As such, I actually think it is a mistake to consider 'noop' as "drop _this_ commit"; the remainder of the line that begins with 'noop' does not name any commit. ```