# [PATCH] test_bitmap_walk: free bitmap with bitmap_free 2 messages from 2015-05-22 to 2015-05-22. Participants: Jeff King, Stefan Beller. Thread: https://gitlist.dev/t/39404 ## Jeff King, 2015-05-22 00:53 Subject: [PATCH] test_bitmap_walk: free bitmap with bitmap_free Message-ID: <20150522005336.GA26326@peff.net> URL: https://gitlist.dev/e/20150522005336.GA26326%40peff.net ``` Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30) noticed that we leak the "result" bitmap. But we should use "bitmap_free" rather than straight "free", as the former remembers to free the bitmap array pointed to by the struct. Signed-off-by: Jeff King --- Sorry, I should have noticed this when reviewing the original. pack-bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pack-bitmap.c b/pack-bitmap.c index 62a98cc..d64bd94 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -987,7 +987,7 @@ void test_bitmap_walk(struct rev_info *revs) else fprintf(stderr, "Mismatch!\n"); - free(result); + bitmap_free(result); } static int rebuild_bitmap(uint32_t *reposition, -- 2.4.1.528.g00591e3 ``` ## Stefan Beller, 2015-05-22 16:37 Subject: Re: [PATCH] test_bitmap_walk: free bitmap with bitmap_free Message-ID: URL: https://gitlist.dev/e/CAGZ79kZqRE78qFGPcU9xiFDiGG3X0kaBFdH%2BrGhUCZBM3ikUDA%40mail.gmail.com In-Reply-To: <20150522005336.GA26326@peff.net> ``` On Thu, May 21, 2015 at 5:53 PM, Jeff King wrote: > Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30) > noticed that we leak the "result" bitmap. But we should use > "bitmap_free" rather than straight "free", as the former > remembers to free the bitmap array pointed to by the struct. > > Signed-off-by: Jeff King > --- > Sorry, I should have noticed this when reviewing the original. No need to be sorry, me too. This looks good to me. > > pack-bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pack-bitmap.c b/pack-bitmap.c > index 62a98cc..d64bd94 100644 > --- a/pack-bitmap.c > +++ b/pack-bitmap.c > @@ -987,7 +987,7 @@ void test_bitmap_walk(struct rev_info *revs) > else > fprintf(stderr, "Mismatch!\n"); > > - free(result); > + bitmap_free(result); > } > > static int rebuild_bitmap(uint32_t *reposition, > -- > 2.4.1.528.g00591e3 ```