# [PATCH] Fixed translation error (say(_())) functions

2 messages from 2015-05-03 to 2015-05-04. Participants: Alangi Derick, Matthieu Moy.
Thread: https://gitlist.dev/t/39241

## Alangi Derick, 2015-05-03 22:05

Subject: [PATCH] Fixed translation error (say(_())) functions
Message-ID: <554769df.43c8c20a.4b7f.ffffc3cb@mx.google.com>
URL: https://gitlist.dev/e/554769df.43c8c20a.4b7f.ffffc3cb%40mx.google.com

```
Signed-off-by: Alangi Derick <alangiderick@gmail.com>
---
 base85.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/base85.c b/base85.c
index 5ca601e..4160f44 100644
--- a/base85.c
+++ b/base85.c
@@ -78,7 +78,7 @@ int decode_85(char *dst, const char *buffer, int len)
 
 void encode_85(char *buf, const unsigned char *data, int bytes)
 {
-	say("encode 85");
+	say(_("encode 85"));
 	while (bytes) {
 		unsigned acc = 0;
 		int cnt;
@@ -96,7 +96,7 @@ void encode_85(char *buf, const unsigned char *data, int bytes)
 		}
 		buf += 5;
 	}
-	say("\n");
+	say(_("\n"));
 
 	*buf = 0;
 }
-- 
2.4.0.1.gd092831.dirty

```

## Matthieu Moy, 2015-05-04 15:19

Subject: Re: [PATCH] Fixed translation error (say(_())) functions
Message-ID: <vpqpp6ggyjy.fsf@anie.imag.fr>
URL: https://gitlist.dev/e/vpqpp6ggyjy.fsf%40anie.imag.fr
In-Reply-To: <554769df.43c8c20a.4b7f.ffffc3cb@mx.google.com>

```
It seems you are posting putting the list in Bcc. Don't do that: it
makes it painful to reply to your message (I had to re-add git@vger
manually).

Alangi Derick <alangiderick@gmail.com> writes:

> Subject: [PATCH] Fixed translation error (say(_())) functions

Please, read the "(2) Describe your changes well." section of
SubmittingPatches (actually, read the whole document if not done
already, but particularly this section). Your subject does not adhere
the usual format.

> Signed-off-by: Alangi Derick <alangiderick@gmail.com>
> ---
>  base85.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/base85.c b/base85.c
> index 5ca601e..4160f44 100644
> --- a/base85.c
> +++ b/base85.c
> @@ -78,7 +78,7 @@ int decode_85(char *dst, const char *buffer, int len)
>  
>  void encode_85(char *buf, const unsigned char *data, int bytes)
>  {
> -	say("encode 85");
> +	say(_("encode 85"));

These are debug statements (see the top of base85.c). I don't think you
want to translate them.

> @@ -96,7 +96,7 @@ void encode_85(char *buf, const unsigned char *data, int bytes)
>  		}
>  		buf += 5;
>  	}
> -	say("\n");
> +	say(_("\n"));

Same, plus the fact that a \n would not need to be translated anyway I
guess.

Regards,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

```