# [PATCH] t7502-commit.sh: fix a broken and-chain 2 messages from 2015-04-28 to 2015-04-29. Participants: Ramsay Jones, Jeff King. Thread: https://gitlist.dev/t/39179 ## Ramsay Jones, 2015-04-28 12:04 Subject: [PATCH] t7502-commit.sh: fix a broken and-chain Message-ID: <553F775C.3030102@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/553F775C.3030102%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- Hi Junio, This test recently started failing for me. I haven't heard anyone else complaining about this, so maybe I should look into why my environment may be different to everyone else ... :-D (when I can find some time, of course!) ATB, Ramsay Jones t/t7502-commit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh index 051489e..2e0d557 100755 --- a/t/t7502-commit.sh +++ b/t/t7502-commit.sh @@ -370,7 +370,7 @@ exit 0 EOF test_expect_success !AUTOIDENT 'do not fire editor when committer is bogus' ' - >.git/result + >.git/result && >expect && echo >>negative && -- 2.3.0 ``` ## Jeff King, 2015-04-29 02:11 Subject: Re: [PATCH] t7502-commit.sh: fix a broken and-chain Message-ID: <20150429021132.GA438@peff.net> URL: https://gitlist.dev/e/20150429021132.GA438%40peff.net In-Reply-To: <553F775C.3030102@ramsay1.demon.co.uk> ``` On Tue, Apr 28, 2015 at 01:04:44PM +0100, Ramsay Jones wrote: > This test recently started failing for me. I haven't heard anyone > else complaining about this, so maybe I should look into why my > environment may be different to everyone else ... :-D (when I can > find some time, of course!) > > [...] > test_expect_success !AUTOIDENT 'do not fire editor when committer is bogus' ' > - >.git/result > + >.git/result && It looks like 92b269f (test-lib: turn on GIT_TEST_CHAIN_LINT by default, 2015-04-22) made it into pu recently, so you are probably just the first person to test it whose system matches !AUTOIDENT (which in turn is based on things like whether we can come up with a plausible-looking email from your system). Patch itself is obviously correct, and it looks like Junio has already picked it up for pu. Thanks. -Peff ```