# Fix uninteresting tags in new revision parsing 2 messages from 2006-04-19 to 2006-04-19. Participants: Linus Torvalds, Junio C Hamano. Thread: https://gitlist.dev/t/3915 ## Linus Torvalds, 2006-04-19 03:31 Subject: Fix uninteresting tags in new revision parsing Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0604182027460.3701%40g5.osdl.org ``` When I unified the revision argument parsing, I introduced a simple bug wrt tags that had been marked uninteresting. When it was preparing for the revision walk, it would mark all the parent commits of an uninteresting tag correctly uninteresting, but it would forget about the commit itself. This means that when I just did my 2.6.17-rc2 release, and my scripts generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine, except the commit pointed to by 2.6.17-rc1 (which shouldn't have been there) was included. Even though it should obviously have been marked as being uninteresting. Not a huge deal, and the fix is trivial. Signed-off-by: Linus Torvalds --- diff --git a/revision.c b/revision.c index dbd54da..113dd5a 100644 --- a/revision.c +++ b/revision.c @@ -152,6 +152,7 @@ static struct commit *handle_commit(stru if (parse_commit(commit) < 0) die("unable to parse commit %s", name); if (flags & UNINTERESTING) { + commit->object.flags |= UNINTERESTING; mark_parents_uninteresting(commit); revs->limited = 1; } ``` ## Junio C Hamano, 2006-04-19 04:36 Subject: Re: Fix uninteresting tags in new revision parsing Message-ID: <7vu08qb2qo.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vu08qb2qo.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Linus Torvalds writes: > When I unified the revision argument parsing, I introduced a simple bug > wrt tags that had been marked uninteresting. When it was preparing for the > revision walk, it would mark all the parent commits of an uninteresting > tag correctly uninteresting, but it would forget about the commit itself. Thanks. Can't believe I missed it... ```