# [PATCH] Fix settings in default_user_config template

5 messages from 2015-04-17 to 2015-04-17. Participants: Ossi Herrala, Jeff King, Junio C Hamano.
Thread: https://gitlist.dev/t/39101

## Ossi Herrala, 2015-04-17 14:50

Subject: [PATCH] Fix settings in default_user_config template
Message-ID: <1429282210-38538-1-git-send-email-oherrala@gmail.com>
URL: https://gitlist.dev/e/1429282210-38538-1-git-send-email-oherrala%40gmail.com

```
The name (not user) and email setting should be in config section
"user" and not in "core" as documented in Documentation/config.txt.
---
 builtin/config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/config.c b/builtin/config.c
index d32c532..bfd3016 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -455,9 +455,9 @@ static char *default_user_config(void)
 	struct strbuf buf = STRBUF_INIT;
 	strbuf_addf(&buf,
 		    _("# This is Git's per-user configuration file.\n"
-		      "[core]\n"
+		      "[user]\n"
 		      "# Please adapt and uncomment the following lines:\n"
-		      "#	user = %s\n"
+		      "#	name = %s\n"
 		      "#	email = %s\n"),
 		    ident_default_name(),
 		    ident_default_email());
-- 
2.3.5

```

## Jeff King, 2015-04-17 14:55

Subject: Re: [PATCH] Fix settings in default_user_config template
Message-ID: <20150417145516.GB2421@peff.net>
URL: https://gitlist.dev/e/20150417145516.GB2421%40peff.net
In-Reply-To: <1429282210-38538-1-git-send-email-oherrala@gmail.com>

```
On Fri, Apr 17, 2015 at 05:50:10PM +0300, Ossi Herrala wrote:

> The name (not user) and email setting should be in config section
> "user" and not in "core" as documented in Documentation/config.txt.

<facepalm> Well, those probably weren't helping any new users, then,
were they? :)

> diff --git a/builtin/config.c b/builtin/config.c
> index d32c532..bfd3016 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -455,9 +455,9 @@ static char *default_user_config(void)
>  	struct strbuf buf = STRBUF_INIT;
>  	strbuf_addf(&buf,
>  		    _("# This is Git's per-user configuration file.\n"
> -		      "[core]\n"
> +		      "[user]\n"
>  		      "# Please adapt and uncomment the following lines:\n"
> -		      "#	user = %s\n"
> +		      "#	name = %s\n"
>  		      "#	email = %s\n"),

Looks obviously correct. Thanks for noticing.

-Peff

```

## Ossi Herrala, 2015-04-17 17:08

Subject: [PATCH] Fix settings in default_user_config template
Message-ID: <1429290535-38647-1-git-send-email-oherrala@gmail.com>
URL: https://gitlist.dev/e/1429290535-38647-1-git-send-email-oherrala%40gmail.com
In-Reply-To: <20150417145516.GB2421@peff.net>

```
The name (not user) and email setting should be in config section
"user" and not in "core" as documented in Documentation/config.txt.

Signed-Off-By: Ossi Herrala <oherrala@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>

```

## Ossi Herrala, 2015-04-17 17:08

Subject: [PATCH] Fix settings in default_user_config template
Message-ID: <1429290535-38647-2-git-send-email-oherrala@gmail.com>
URL: https://gitlist.dev/e/1429290535-38647-2-git-send-email-oherrala%40gmail.com
In-Reply-To: <1429290535-38647-1-git-send-email-oherrala@gmail.com>

```
The name (not user) and email setting should be in config section
"user" and not in "core" as documented in Documentation/config.txt.
---
 builtin/config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/config.c b/builtin/config.c
index d32c532..bfd3016 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -455,9 +455,9 @@ static char *default_user_config(void)
 	struct strbuf buf = STRBUF_INIT;
 	strbuf_addf(&buf,
 		    _("# This is Git's per-user configuration file.\n"
-		      "[core]\n"
+		      "[user]\n"
 		      "# Please adapt and uncomment the following lines:\n"
-		      "#	user = %s\n"
+		      "#	name = %s\n"
 		      "#	email = %s\n"),
 		    ident_default_name(),
 		    ident_default_email());
-- 
2.3.5

```

## Junio C Hamano, 2015-04-17 17:33

Subject: Re: [PATCH] Fix settings in default_user_config template
Message-ID: <xmqq1tjir76b.fsf@gitster.dls.corp.google.com>
URL: https://gitlist.dev/e/xmqq1tjir76b.fsf%40gitster.dls.corp.google.com
In-Reply-To: <1429290535-38647-1-git-send-email-oherrala@gmail.com>

```
Ossi Herrala <oherrala@gmail.com> writes:

> The name (not user) and email setting should be in config section
> "user" and not in "core" as documented in Documentation/config.txt.
>
> Signed-Off-By: Ossi Herrala <oherrala@gmail.com>
> Reviewed-by: Jeff King <peff@peff.net>

Thanks ;-)

```