# [PATCH] CodingGuidelines: updating 'rough' rule count 7 messages from 2015-04-12 to 2015-04-13. Participants: Julian Gindi, Eric Sunshine, Jonathan Nieder. Thread: https://gitlist.dev/t/39057 ## Julian Gindi, 2015-04-12 23:47 Subject: [PATCH] CodingGuidelines: updating 'rough' rule count Message-ID: <20150412234720.GA37658@Serenity.local> URL: https://gitlist.dev/e/20150412234720.GA37658%40Serenity.local ``` Changed inaccurate count of "rough rules" from three to four. Signed-off-by: Julian Gindi --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 0f8cccf..c422ecd 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -1,5 +1,5 @@ Like other projects, we also have some guidelines to keep to the -code. For Git in general, three rough rules are: +code. For Git in general, four rough rules are: - Most importantly, we never say "It's in POSIX; we'll happily ignore your needs should your system not conform to it." -- 2.3.5 ``` ## Eric Sunshine, 2015-04-13 00:04 Subject: Re: [PATCH] CodingGuidelines: updating 'rough' rule count Message-ID: URL: https://gitlist.dev/e/CAPig%2BcS%3DxBoe-hr5Kwm0N9hBUy4bzN1NoXTcDEwz_4ZwrrXPXA%40mail.gmail.com In-Reply-To: <20150412234720.GA37658@Serenity.local> ``` On Sun, Apr 12, 2015 at 7:47 PM, Julian Gindi wrote: > Changed inaccurate count of "rough rules" from three to four. > > Signed-off-by: Julian Gindi > --- > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index 0f8cccf..c422ecd 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -1,5 +1,5 @@ > Like other projects, we also have some guidelines to keep to the > -code. For Git in general, three rough rules are: > +code. For Git in general, four rough rules are: Although this change is technically accurate, this sentence is still a potential maintenance burden. How about taking a more generic approach, and saying something like: For Git, in general, the rough rules are: ? > - Most importantly, we never say "It's in POSIX; we'll happily > ignore your needs should your system not conform to it." > -- > 2.3.5 ``` ## Julian Gindi, 2015-04-13 04:26 Subject: Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count Message-ID: <20150413042644.GA39596@Serenity.local> URL: https://gitlist.dev/e/20150413042644.GA39596%40Serenity.local In-Reply-To: ``` Changed inaccurate count of "rough rules" from three to the more generic 'a few'. --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 0f8cccf..2dd35bd 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -1,5 +1,5 @@ Like other projects, we also have some guidelines to keep to the -code. For Git in general, three rough rules are: +code. For Git in general, a few rough rules are: - Most importantly, we never say "It's in POSIX; we'll happily ignore your needs should your system not conform to it." -- 2.3.5 ``` ## Eric Sunshine, 2015-04-13 05:00 Subject: Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count Message-ID: URL: https://gitlist.dev/e/CAPig%2BcTgNzO5NGabOsaSZOq7Y47OBXJz9mnS-MfpoQ2MANzrng%40mail.gmail.com In-Reply-To: <20150413042644.GA39596@Serenity.local> ``` On Mon, Apr 13, 2015 at 12:26 AM, Julian Gindi wrote: > CodingGuidelines: updating 'rough' rule count Imperative mood is preferred, so "update" rather than "updating": CodingGuidelines: update 'rough' rule count > Changed inaccurate count of "rough rules" from three to the more > generic 'a few'. Imperative: s/Changed/Change/ > --- Missing sign-off. > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index 0f8cccf..2dd35bd 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -1,5 +1,5 @@ > Like other projects, we also have some guidelines to keep to the > -code. For Git in general, three rough rules are: > +code. For Git in general, a few rough rules are: Looks better, thanks. > - Most importantly, we never say "It's in POSIX; we'll happily > ignore your needs should your system not conform to it." > -- > 2.3.5 ``` ## Eric Sunshine, 2015-04-13 05:04 Subject: Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count Message-ID: URL: https://gitlist.dev/e/CAPig%2BcQ3z_UuUMZE_jUGbv1_3Fu_32GSw2ysSixw4VE0opz27w%40mail.gmail.com In-Reply-To: ``` On Mon, Apr 13, 2015 at 1:00 AM, Eric Sunshine wrote: > On Mon, Apr 13, 2015 at 12:26 AM, Julian Gindi wrote: >> Changed inaccurate count of "rough rules" from three to the more >> generic 'a few'. > > Imperative: s/Changed/Change/ I forgot to mention the unusual 2-space indentation of the log message. It should be left-justified. ``` ## Julian Gindi, 2015-04-13 12:54 Subject: Re: [PATCH v3] CodingGuidelines: update 'rough' rule count Message-ID: <20150413125414.GA1038@Serenity.local> URL: https://gitlist.dev/e/20150413125414.GA1038%40Serenity.local In-Reply-To: ``` Changed inaccurate count of "rough rules" from three to the more generic 'a few'. Signed-off-by: Julian Gindi --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 0f8cccf..2dd35bd 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -1,5 +1,5 @@ Like other projects, we also have some guidelines to keep to the -code. For Git in general, three rough rules are: +code. For Git in general, a few rough rules are: - Most importantly, we never say "It's in POSIX; we'll happily ignore your needs should your system not conform to it." -- 2.3.5 ``` ## Jonathan Nieder, 2015-04-13 17:30 Subject: Re: [PATCH v3] CodingGuidelines: update 'rough' rule count Message-ID: <20150413173002.GC5467@google.com> URL: https://gitlist.dev/e/20150413173002.GC5467%40google.com In-Reply-To: <20150413125414.GA1038@Serenity.local> ``` Julian Gindi wrote: > Changed inaccurate count of "rough rules" from three to the more > generic 'a few'. > > Signed-off-by: Julian Gindi Reviewed-by: Jonathan Nieder Thanks. ```