threads / discuss / 39037

Notes do not follow rebase

Subject: Notes do not follow rebase

## tl;dr

2 messages between Apr 8, 2015 and Apr 8, 2015.

replies: 1people: 2as markdown or json

Phillip Susi· Apr 8, 2015, 18:40 UTC · lore

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

After doing a rebase -i to fix up some older commits, I noticed that notes I had associated with commits failed to follow the commit across the rebase, so the notes are now orphaned and will be pruned. Shouldn't notes be copied to the new commit during an ammend/rebase?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVJXY7AAoJENRVrw2cjl5RUe8IAI0tGUeBUAef4xIIU/UfV5eQ VAdkUfYXCHnkjqukS/iBusyNM3PssabHmRFc+AdKGPPmbsv9JGKpj5G9hwf6Bdh+ RNDPMTlt/Ii90eu+v3uXwFHNUNf0b6kv7Tw63L0bFxGsFzu55DBm48LT/DJ9T05x Yqz5hbisKAhiVfAep2ib32f8gvC6p47CBmKVY4ii/PpOIzX/clZOQEgSPxvuHcSR cVcMGdljG+n8UqEOkkX5im0cW7pOUUht5GXWRGnBjXjtKTG64zxZnBPsPcqVJtxT q/lloKerUktJH3bJbUDU6iefBBzukQyy6tF37nbZH68bwTBlrh8CGL1BT2Eviqs= =WyFy -----END PGP SIGNATURE-----

Johan Herland· Apr 8, 2015, 22:56 UTC · re: Phillip Susi · lore

Re: Notes do not follow rebase

On Wed, Apr 8, 2015 at 8:40 PM, Phillip Susi <psusi@ubuntu.com> wrote:

> After doing a rebase -i to fix up some older commits, I noticed that
> notes I had associated with commits failed to follow the commit across
> the rebase, so the notes are now orphaned and will be pruned.
> Shouldn't notes be copied to the new commit during an ammend/rebase?

It depends. Which notes do you want copied? (i.e. from which notes ref?) Please have a look at the notes.rewriteRef config option (documented in the git-config and git-notes manual pages)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net