threads / discuss / 38950

Walking children commits?

Subject: Walking children commits?

## tl;dr

3 messages between Mar 30, 2015 and Mar 30, 2015.

replies: 2people: 1as markdown or json

Mike Hommey· Mar 30, 2015, 23:02 UTC · lore

Hi,

I am trying to get all the children commits of a set of commits. To do that, I'm using this:

  git rev-list --topo-order --ancestry-path --boundary <all heads> ^A ^B ...

where A, B, and following are those commits I want the children of. From the gitrevisions documentation, it seems that should get me what I want, but if I build a dag manually (from the output of rev-list --parents) and get all the children of those commits, I get more results than what the command above returns (and that command also gives false positives).

Am I doing something wrong, or am I hitting a bug in --ancestry-path walking? In the latter case, I'll try to find a reduced test case, because currently, this involves a 260k commit, 1.5GB repository with close to 2k heads and a set of 153 commits to find the children of.

Cheers,

Mike

Mike Hommey· Mar 30, 2015, 23:35 UTC · re: Mike Hommey · lore

Re: Walking children commits?

On Tue, Mar 31, 2015 at 08:02:09AM +0900, Mike Hommey wrote:

Show 12 quoted lines

> Hi,
> 
> I am trying to get all the children commits of a set of commits. To do
> that, I'm using this:
> 
>   git rev-list --topo-order --ancestry-path --boundary <all heads> ^A ^B ...
> 
> where A, B, and following are those commits I want the children of. From
> the gitrevisions documentation, it seems that should get me what I want,
> but if I build a dag manually (from the output of rev-list --parents)
> and get all the children of those commits, I get more results than what
> the command above returns (and that command also gives false positives).

The false positives are actually boundaries other than A, B, etc. so I'd actually need to remove --boundary and add A, B to the result manually. That still leaves the missing results, though.

Mike

Mike Hommey· Mar 30, 2015, 23:44 UTC · re: Mike Hommey · lore

Re: Walking children commits?

On Tue, Mar 31, 2015 at 08:35:52AM +0900, Mike Hommey wrote:

Show 17 quoted lines

> On Tue, Mar 31, 2015 at 08:02:09AM +0900, Mike Hommey wrote:
> > Hi,
> > 
> > I am trying to get all the children commits of a set of commits. To do
> > that, I'm using this:
> > 
> >   git rev-list --topo-order --ancestry-path --boundary <all heads> ^A ^B ...
> > 
> > where A, B, and following are those commits I want the children of. From
> > the gitrevisions documentation, it seems that should get me what I want,
> > but if I build a dag manually (from the output of rev-list --parents)
> > and get all the children of those commits, I get more results than what
> > the command above returns (and that command also gives false positives).
> 
> The false positives are actually boundaries other than A, B, etc. so I'd
> actually need to remove --boundary and add A, B to the result manually.
> That still leaves the missing results, though.

Ah, the missing results are commits that both are part of the set of commits and are heads... So all in all --ancestry-path works for my use case, but I need post-processing.

Mike