threads / patch / 38874

patcht6039: fix broken && chain

Subject: [PATCH] t6039: fix broken && chain

## tl;dr

4 messages between Mar 21, 2015 and Mar 21, 2015. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Torsten Bögershausen· Mar 21, 2015, 07:04 UTC · lore

Add missing %%, detected by the --chain-lint option
---
 t/t6039-merge-ignorecase.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t6039-merge-ignorecase.sh +1 −1

diff --git a/t/t6039-merge-ignorecase.sh b/t/t6039-merge-ignorecase.sh
index a977653..531850d 100755
--- a/t/t6039-merge-ignorecase.sh
+++ b/t/t6039-merge-ignorecase.sh
@@ -15,7 +15,7 @@ test_expect_success 'merge with case-changing rename' '
 	>TestCase &&
 	git add TestCase &&
 	git commit -m "add TestCase" &&
-	git tag baseline
+	git tag baseline &&
 	git checkout -b with-camel &&
 	>foo &&
 	git add foo &&

-- 
2.2.0.rc1.790.ge19fcd2

Torsten Bögershausen· Mar 21, 2015, 07:19 UTC · re: Torsten Bögershausen · lore

Re: [PATCH] t6039: fix broken && chain

On 2015-03-21 08.04, Torsten Bögershausen wrote:

> Add missing %%, detected by the --chain-lint option

Oh, early morning typo, should be Add missing &&, detected by the --chain-lint option

(I'll re-run the testsuite with the  --chain-lint in a minute,
 thanks everybody for this nice feature)

Jeff King· Mar 21, 2015, 07:35 UTC · re: Torsten Bögershausen · lore

Re: [PATCH] t6039: fix broken && chain

On Sat, Mar 21, 2015 at 08:19:20AM +0100, Torsten Bögershausen wrote:

Show 7 quoted lines

> On 2015-03-21 08.04, Torsten Bögershausen wrote:
> > Add missing %%, detected by the --chain-lint option
> Oh, early morning typo, should be
> Add missing &&, detected by the --chain-lint option
> 
> (I'll re-run the testsuite with the  --chain-lint in a minute,
>  thanks everybody for this nice feature)

Yay! I'm glad to see it detecting something, and people trying it out on platforms with different prereqs than mine.

-Peff

Junio C Hamano· Mar 21, 2015, 18:04 UTC · re: Torsten Bögershausen · lore

Re: [PATCH] t6039: fix broken && chain

Torsten Bögershausen <tboegi@web.de> writes:

Show 7 quoted lines

> On 2015-03-21 08.04, Torsten Bögershausen wrote:
>> Add missing %%, detected by the --chain-lint option
> Oh, early morning typo, should be
> Add missing &&, detected by the --chain-lint option
>
> (I'll re-run the testsuite with the  --chain-lint in a minute,
>  thanks everybody for this nice feature)

Yes, it is nice to see people helping prereq holes other people may inevitably have.

Sign-off?