threads / rfc / 38848

RFC patchgrep: fix "--quiet" overwriting current output

Subject: [PATCH/RFC] grep: fix "--quiet" overwriting current output

## tl;dr

2 messages between Mar 18, 2015 and Mar 18, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Wilhelm Schuermann· Mar 18, 2015, 18:00 UTC · lore

When grep is called with the --quiet option, the pager is initialized despite not being used. When the pager is "less", anything output by previous commands and not ended with a newline is overwritten.

$ echo -n aaa; echo bbb aaabbb $ echo -n aaa; git grep -q foo; echo bbb bbb

This can be worked around, for example, by making sure STDOUT is not a TTY or more directly by setting git's pager to "cat":

$ echo -n aaa; git grep -q foo > /dev/null; echo bbb aaabbb $ echo -n aaa; PAGER=cat git grep -q foo; echo bbb aaabbb

This patch prevents calling the pager in the first place, saving an unnecessary fork() call.

Signed-off-by: Wilhelm Schuermann <wimschuermann@googlemail.com>
---
 builtin/grep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/grep.c +1 −1

diff --git a/builtin/grep.c b/builtin/grep.c
index e77f7cf..fe7b9fd 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@ -885,7 +885,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
 		}
 	}
 
-	if (!show_in_pager)
+	if (!show_in_pager && !opt.status_only)
 		setup_pager();
 
 	if (!use_index && (untracked || cached))

-- 
2.3.3.dirty

Jeff King· Mar 18, 2015, 19:01 UTC · re: Wilhelm Schuermann · lore

Re: [PATCH/RFC] grep: fix "--quiet" overwriting current output

On Wed, Mar 18, 2015 at 07:00:13PM +0100, Wilhelm Schuermann wrote:

Show 6 quoted lines

> When grep is called with the --quiet option, the pager is initialized
> despite not being used.  When the pager is "less", anything output by
> previous commands and not ended with a newline is overwritten.
> [...]
> This patch prevents calling the pager in the first place, saving an
> unnecessary fork() call.

Thanks, I think this makes sense. We do a similar thing for "git diff --quiet". If you do not set "-F" in your $LESS variable, it is even more annoying. E.g., with:

  if git grep -q foo; then
    : do something
  fi

which will pause, waiting for the user to hit 'q'.

Show 11 quoted lines

> diff --git a/builtin/grep.c b/builtin/grep.c
> index e77f7cf..fe7b9fd 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -885,7 +885,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
>  		}
>  	}
>  
> -	if (!show_in_pager)
> +	if (!show_in_pager && !opt.status_only)
>  		setup_pager();

Patch looks obviously correct.

-Peff